bugGNU Octave - Bugs: bug #39038, glpk-4.49 removed routines whose...

 
 

bug #39038: glpk-4.49 removed routines whose names begin with 'lpx_'

Submitted by:  marco atzeri <matzeri>
Submitted on:  Wed 22 May 2013 12:04:46 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 14 Aug 2013 01:48:51 AM UTC, comment #7:

Just to record it here, I pushed the following changeset to check for the new GLPK functionality:

http://hg.savannah.gnu.org/hgweb/octave/rev/03a666018e0f

Mike Miller <mtmiller>
Project Administrator
Tue 06 Aug 2013 10:17:23 PM UTC, comment #6:

I already went ahead and identified which versions of GLPK introduced each of the functions that failed with an ancient version as shown in comment #5. I'll add a test to configure.ac for the newest set of GLPK API changes that Octave now requires.

Mike Miller <mtmiller>
Project Administrator
Mon 05 Aug 2013 09:57:21 PM UTC, comment #5:

This change breaks compilation with older glpk, which was noted in an earlier comment. I have no problem with that, but the current tests in configure.ac are insufficient, more/better tests are needed to avoid trying to use an older version.

Mike Miller <mtmiller>
Project Administrator
Mon 05 Aug 2013 06:18:19 PM UTC, comment #4:

Sebastien, this is a great patch! Thanks!

I have applied it and built Octave and the test suite works. I have also looked superficially at your patch and it looks good. And since you're a pretty cool guy, I trust your expertise here and have pushed your patch to Savannah:

http://hg.savannah.gnu.org/hgweb/octave/rev/54e251e699bb

I have rebased your patch in Savannah, so you may want to get rid of your pre-rebased version:

hg strip -r 521b05307fe

Thanks again. I'm closing this report. If problem persist, we can reopen it.

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Sat 03 Aug 2013 02:36:11 PM UTC, comment #3:

I attach a changeset that fixes this issue. I verified it against GLPK 4.45 and GLPK 4.52.1.

In order to reflect the API changes in GLPK, I made some changes to the interface of the glpk.m function. I have however tried to keep them minimal, and I have documented them in the NEWS file.

Note that I could not use patch #7521, since the latter has its own problems and still uses some routines from the deprecated API.

(file #28747)

Sébastien Villemot <svillemot>
Tue 25 Jun 2013 12:28:28 PM UTC, comment #2:

I suspect not relevant.

The old interface was for compatibility with previous software.
The new interface seems already there in version 4.31.
I have not checked all the history changes.

marco atzeri <matzeri>
Tue 25 Jun 2013 11:09:46 AM UTC, comment #1:

How important is it to support old versions of glpk?

Can we simply update Octave to use the new interface instead?

John W. Eaton <jwe>
Project Administrator
Wed 22 May 2013 12:04:46 PM UTC, original submission:

with latest glpk-4.49 build

  • glpk.h

All old API routines whose names begin with 'lpx_'
were removed from API and no more available.

so libinterp/dldfcn/__glpk__.cc does not compile anymore.

marco atzeri <matzeri>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28747:  glpk.diff added by svillemot (37KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by svillemot (Updated the item)
  • -unavailable- added by svillemot
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by matzeri (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 05 Aug 2013 06:18:19 PM UTCjordighStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 03 Aug 2013 02:36:11 PM UTCsvillemotAttached File-=>Added glpk.diff, #28747
    Tue 25 Jun 2013 08:28:13 PM UTCsvillemotCarbon-Copy-=>Added svillemot

    Back to the top


    Powered by Savane 3.1-cleanup1