bugGNU Octave - Bugs: bug #39038, glpk-4.49 removed routines whose...

 
 

bug #39038: glpk-4.49 removed routines whose names begin with 'lpx_'

Submitter:  marco atzeri <matzeri>
Submitted:  Wed 22 May 2013 12:04:46 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 14 Aug 2013 01:48:51 AM UTC, comment #7: 

Just to record it here, I pushed the following changeset to check for the new GLPK functionality:

http://hg.savannah.gnu.org/hgweb/octave/rev/03a666018e0f

Mike Miller <mtmiller>
Group Member
Tue 06 Aug 2013 10:17:23 PM UTC, comment #6: 

I already went ahead and identified which versions of GLPK introduced each of the functions that failed with an ancient version as shown in comment #5. I'll add a test to configure.ac for the newest set of GLPK API changes that Octave now requires.

Mike Miller <mtmiller>
Group Member
Mon 05 Aug 2013 09:57:21 PM UTC, comment #5: 

This change breaks compilation with older glpk, which was noted in an earlier comment. I have no problem with that, but the current tests in configure.ac are insufficient, more/better tests are needed to avoid trying to use an older version.


.../libinterp/dldfcn/__glpk__.cc:173: error: 'glp_write_lp' was not declared in this scope
.../libinterp/dldfcn/__glpk__.cc:182: error: 'glp_scale_prob' was not declared in this scope
.../libinterp/dldfcn/__glpk__.cc:186: error: 'glp_adv_basis' was not declared in this scope
.../libinterp/dldfcn/__glpk__.cc:224: error: 'struct glp_iocp' has no member named 'presolve'
.../libinterp/dldfcn/__glpk__.cc:230: error: 'glp_iptcp' was not declared in this scope
.../libinterp/dldfcn/__glpk__.cc:230: error: expected `;' before 'iptcp'
.../libinterp/dldfcn/__glpk__.cc:231: error: 'iptcp' was not declared in this scope
.../libinterp/dldfcn/__glpk__.cc:231: error: 'glp_init_iptcp' was not declared in this scope
.../libinterp/dldfcn/__glpk__.cc:233: error: 'glp_interior' was not declared in this scope


Mike Miller <mtmiller>
Group Member
Mon 05 Aug 2013 06:18:19 PM UTC, comment #4: 

Sebastien, this is a great patch! Thanks!

I have applied it and built Octave and the test suite works. I have also looked superficially at your patch and it looks good. And since you're a pretty cool guy, I trust your expertise here and have pushed your patch to Savannah:

    http://hg.savannah.gnu.org/hgweb/octave/rev/54e251e699bb

I have rebased your patch in Savannah, so you may want to get rid of your pre-rebased version:

    hg strip -r 521b05307fe

Thanks again. I'm closing this report. If problem persist, we can reopen it.

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Sat 03 Aug 2013 02:36:11 PM UTC, comment #3: 

I attach a changeset that fixes this issue. I verified it against GLPK 4.45 and GLPK 4.52.1.

In order to reflect the API changes in GLPK, I made some changes to the interface of the glpk.m function. I have however tried to keep them minimal, and I have documented them in the NEWS file.

Note that I could not use patch #7521, since the latter has its own problems and still uses some routines from the deprecated API.


(file #28747)

Sébastien Villemot <svillemot>
Tue 25 Jun 2013 12:28:28 PM UTC, comment #2: 

I suspect not relevant.

The old interface was for compatibility with previous software.
The new interface seems already there in version 4.31.
I have not checked all the history changes.




marco atzeri <matzeri>
Tue 25 Jun 2013 11:09:46 AM UTC, comment #1: 

How important is it to support old versions of glpk?

Can we simply update Octave to use the new interface instead?

John W. Eaton <jwe>
Group administrator
Wed 22 May 2013 12:04:46 PM UTC, original submission:  

with latest glpk-4.49 build

  • glpk.h

  All old API routines whose names begin with 'lpx_'
  were removed from API and no more available.

so libinterp/dldfcn/__glpk__.cc does not compile anymore.


marco atzeri <matzeri>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #28747:  glpk.diff added by svillemot (37KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by svillemot (Updated the item)
  • -email is unavailable- added by svillemot
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by matzeri (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-08-05 jordigh StatusNone Fixed
        Open/ClosedOpen Closed
    2013-08-03 svillemot Attached File- Added glpk.diff, #28747
    2013-06-25 svillemot Carbon-Copy- Added svillemot

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code