bugGNU Octave - Bugs: bug #39010, strsplit returns incorrect result...

 
 

bug #39010: strsplit returns incorrect result if target string contains only delimiters

Submitted by:  John W. Eaton <jwe>
Submitted on:  Thu 16 May 2013 07:04:59 PM UTC  
 
Category: Octave FunctionSeverity: 5 - Blocker
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Ben Abbott <bpabbott>
Originator Name: jweOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 22 Jun 2013 03:28:34 AM UTC, comment #4:

There have been no reports of problems, so I'm setting the status to "Fixed" and closing this report.

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Thu 06 Jun 2013 03:25:15 AM UTC, comment #3:

I've pushed a few changesets which should resolve this bug.

Re-introduce the original strsplit() as ostrsplit().
http://hg.savannah.gnu.org/hgweb/octave/rev/45b57ac44854

Replace strsplit() with ostrsplit() in Octave's sources.
http://hg.savannah.gnu.org/hgweb/octave/rev/b7667fcb9fbc

Add ostrsplit() to the manual.
http://hg.savannah.gnu.org/hgweb/octave/rev/57bf164f1608

Mention ostrsplit() in NEWS
http://hg.savannah.gnu.org/hgweb/octave/rev/694883adb279

Remove legacy support from strsplit()
http://hg.savannah.gnu.org/hgweb/octave/rev/3ce3579405f8

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Fri 17 May 2013 12:44:18 PM UTC, comment #2:

I just noticed I can export the entire patch via "outgoing -p". It is attached.

(file #28100)

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Fri 17 May 2013 11:53:54 AM UTC, comment #1:

I had decided that the proper thing to do was to back out the changes to strsplit and start over by renaming the original and then introducing a new function.

I did the following.

During which I had some merge problems. I think I've got it worked out, but am in unfamiliar territory, so I'm a bit nervous.

I check the number of "heads"

And the outgoing says,

If all looks good, I can push this change.

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Thu 16 May 2013 07:04:59 PM UTC, original submission:

The following call to strsplit should return a cell array containing two empty character strings but it currently returns an empty cell array.

I tagged this as a blocker so that it won't be forgotten before the next release.

John W. Eaton <jwe>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28100:  strsplit-backout.patch added by bpabbott (59KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bpabbott (Posted a comment)
  • -unavailable- added by jwe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Jun 2013 03:28:34 AM UTCbpabbottStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 06 Jun 2013 03:25:15 AM UTCbpabbottStatusIn Progress=>Ready For Test
    Fri 17 May 2013 12:44:18 PM UTCbpabbottAttached File-=>Added strsplit-backout.patch, #28100

    Back to the top


    Powered by Savane 3.1-cleanup1