bugGNU Octave - Bugs: bug #38724, "Find" feature in editor...

 
 

bug #38724: "Find" feature in editor incomplete

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Fri 12 Apr 2013 04:37:42 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 15 Apr 2013 09:55:52 PM UTC, comment #9:

Works OK! (under Windows, forgot to try under Linux.)

Thanks very much for your patience & fixing this.

Closing this report

Philip Nienhuis <philipnienhuis>
Project Member
Mon 15 Apr 2013 08:54:36 PM UTC, comment #8:

Thanks very much Torsten. I cannot try tonight anymore, will let you know tomorrow night or even Wednesday-night (work keeps me busy).

Philip Nienhuis <philipnienhuis>
Project Member
Mon 15 Apr 2013 08:37:58 PM UTC, comment #7:

Added "Find Previous" button and the dialog window is placed at the right border of the editor widget and pushed change with cs
http://hg.savannah.gnu.org/hgweb/octave/rev/086b5e81245b

Philip, I hope the positioning also works for you. If yes, the bug report can be closed.

Torsten <ttl>
Project Member
Sun 14 Apr 2013 08:35:56 PM UTC, comment #6:

No joy.
Attached is a screen pic of top left part of my WinXP desktop. As you can see the title bar (if it is there on Windows, but I have no reason to assume it's not) is out of (=above) screen limits.

Note that on Linux the title bar is shown. On Linux the find dialog is also in the top left corner, but with the dialog title bar within screen limits.

FYI, my desktop has a 1900x1200 resolution (26").

What might help is to pop up the find dialog somewhere else on the screen, e.g. right in the middle, or better, somewhere over the GUI. Is that feasible with Qt?

BTW what about a "Find Previous" button?

(status set to "in progress")

(file #27873)

Philip Nienhuis <philipnienhuis>
Project Member
Sun 14 Apr 2013 07:18:57 PM UTC, comment #5:

Once again, the "missing" title bar maybe just that there <b>is</b> a title bar, but Octave has initially shifted the find dialog window so high on the screen that the title bar part gets "above" the screen. On Windows this means that one cannot move that screen around as the "handle"(i.e., title bar) is out of reach.

Anyway I've pulled/updated & applied the patch. Building now, then an MXE build + transfer to Windows + trying, I hope if I can get to testing it tonight.

Thanks! and I'll let you know.

Philip Nienhuis <philipnienhuis>
Project Member
Sun 14 Apr 2013 06:55:19 PM UTC, comment #4:

Sorry, wrong patch! Please use this one.

(file #27872)

Torsten <ttl>
Project Member
Sun 14 Apr 2013 06:44:49 PM UTC, comment #3:

Added a close button with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/7af39cc90982

Currently I have no idea about the issue with the missing title bar. Could you please test the attached patch (I have no windows version available at the moment)?

(file #27871)

Torsten <ttl>
Project Member
Sun 14 Apr 2013 11:03:06 AM UTC, comment #2:

Thanks Torsten,

Works beautifully now. Tested on Windows (MXE), haven't tried on Linux yet. Maybe later tonight I can try.

Only things are:
- It isn't obvious how to close that window (Esc key does the trick), so maybe we need a "Cancel" button
- On Windows I cannot move it out of the top left corner of the screen
(Both issues may be due to the title bar being outside screen limits?)

Philip Nienhuis <philipnienhuis>
Project Member
Sat 13 Apr 2013 02:10:51 PM UTC, comment #1:

Changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/eee1b78d031f
should fix the issues.

"Search from start/end" is automatically unchecked after the first match.

Torsten <ttl>
Project Member
Fri 12 Apr 2013 04:37:42 PM UTC, original submission:

(Just that these issues aren't forgotten)

1. "Search from start" only finds the very first match. If this is intended, why not call this option "Find first match"?
(That is: I'd suppose "Search from start" would mean s/th like 'for a new search (string) start looking for the first match at the top of file, for subsequent matches go down from there'.)

2. "Search backward" doesn't work at all for me. It only finds one match and stays there.
In case of "Search backward" the other option "Search from start" should morph into "Search from bottom"?

3. It would be nice to have a 'Not found' message if no match was found.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27872:  find_title_bar_1.diff added by ttl (456B - text/x-diff)
file #27871:  find_title_bar.diff added by ttl (457B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ttl (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 15 Apr 2013 09:55:52 PM UTCphilipnienhuisStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sun 14 Apr 2013 08:35:56 PM UTCphilipnienhuisAttached File-=>Added OctGUI_find-dlg.png, #27873
      StatusFixed=>In Progress
    Sun 14 Apr 2013 06:55:19 PM UTCttlAttached File-=>Added find_title_bar_1.diff, #27872
    Sun 14 Apr 2013 06:44:49 PM UTCttlAttached File-=>Added find_title_bar.diff, #27871
      Open/ClosedClosed=>Open
    Sat 13 Apr 2013 02:10:51 PM UTCttlStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1