bugGNU Octave - Bugs: bug #38518, make dist produces a bad source...

 
 

bug #38518: make dist produces a bad source package when Qt not present

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Thu 14 Mar 2013 08:44:40 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: Mike Miller <mtmiller>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 16 Mar 2013 08:46:19 PM UTC, comment #2:

Fixed in the following changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/7d0848353eaf

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Fri 15 Mar 2013 11:52:05 PM UTC, comment #1:

I've done a couple tests and I think this is doable with some small fixes to the libgui directory.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 14 Mar 2013 08:44:40 PM UTC, original submission:

When Qt is not found, or if --disable-gui is given, the dist target works but produces an octave source distribution without the libgui subdirectory. Trying to build that source package fails because configure requires libgui/Makefile.in.

The easy solution would be to disable make dist like we do when docs are disabled. But that is mainly because we definitely want the documentation to be in the source distribution, right?

It should be possible, and would be nice, to be able to run make dist without Qt, assuming there are no EXTRA_DIST files under libgui that are generated using any of the Qt tools. I think that's the case but I'm not sure.

Automake definitely allows conditional SUBDIRS that will be entered for dist and distclean targets but not for other make targets.

I discovered this on a Hydra build, where Octave is being built without Qt (so far) and make dist is used to produce a source package that is then built on i686-linux and x86_64-linux. See for example http://hydra.nixos.org/build/4397119/log/tail-reload

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 16 Mar 2013 08:46:19 PM UTCmtmillerStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Fri 15 Mar 2013 11:52:05 PM UTCmtmillerStatusNone=>In Progress
      Assigned toNone=>mtmiller

    Back to the top


    Powered by Savane 3.1-cleanup1