bugGNU Octave - Bugs: bug #38455, correct and enhance stemleaf and...

 
 

bug #38455: correct and enhance stemleaf and minor updates to printd

Submitted by:  Michael Godfrey <godfrey>
Submitted on:  Sat 02 Mar 2013 11:11:56 PM UTC  
 
Category: PlottingSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Inaccurate Result
Status: FixedAssigned to: None
Originator Name: Michael GodfreyOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 03 Mar 2013 08:18:55 PM UTC, comment #10:

Also, if you run test stemleaf
from command, it works correctly.
Only, make check fails

Michael Godfrey <godfrey>
Project Member
Sun 03 Mar 2013 08:02:54 PM UTC, comment #9:

Yes,

stemleaf ([0 0.5 1], "")

generates the warning and then does the right
thing. So, I think you are right.

Michael Godfrey <godfrey>
Project Member
Sun 03 Mar 2013 07:59:05 PM UTC, comment #8:

I think the problem is with the warning system. See bug #35850. I tried to fix 35850 and was finding that the %!warning tests would very often print out results of lastwarn() rather than the current warning. This screws up the test system which in this case is expecting "X truncated to integer values" but is getting the string from the last time warning() was called which was probably from a print routine.

Just to be certain that the code itself is working one should try

from the Octave prompt and verify that it generates a warning.

Rik <rik5>
Project Administrator
Sun 03 Mar 2013 05:42:13 PM UTC, comment #7:

I built the latest dev with updated
stemleaf. make check fails as Philip reported.
But, if I run ./run-octave --no-gui
test stemleaf

it passes all 17 tests.

Any ideas as to what is wrong?

Michael Godfrey <godfrey>
Project Member
Sun 03 Mar 2013 03:26:30 PM UTC, comment #6:

Rik,

This all looks great. Thanks, again, for the
cleanup of the code. As usual, I missed a number of
items.

Any idea what causes the "epstool" error reported
by Philip below?

Michael Godfrey <godfrey>
Project Member
Sun 03 Mar 2013 02:55:48 PM UTC, comment #5:

I applied your changeset here (http://hg.savannah.gnu.org/hgweb/octave/rev/3e6d15a2a50b). I also did some cleanup for Octave coding conventions, like space between function name and '(', and removed unused variables left over from previous versions and checked that change in here (http://hg.savannah.gnu.org/hgweb/octave/rev/0f0e970723ec).

Rik <rik5>
Project Administrator
Sun 03 Mar 2013 02:49:58 PM UTC, comment #4:

This is a mystery. The problem does not come
directly from stemleaf. There is nothing in stemleaf
that leads to a reference to epstool. Also, I could
not find anything in the assert code that causes this
(but, I suspect that it is there). I removed epstool
from my system, but this does not induce the error.

Since Rik provided that test, maybe he can provide a
clue.

If you have a minute you might try removing the "tmp ="
from the !warning... at line 598. This is nothing more than
a guess.

Michael Godfrey <godfrey>
Project Member
Sun 03 Mar 2013 10:32:52 AM UTC, comment #3:

[philip@deskprn octave]$ hg summary
parent: 16180:3e6d15a2a50b tip
Update stemleaf to provide new features and minor fix to printd

Mageia 2 Linux

make check gives:

fntests.log:

Could probing for epstool help with polishing stemleaf's output?

Philip Nienhuis <philipnienhuis>
Project Member
Sun 03 Mar 2013 03:21:43 AM UTC, comment #2:

To clarify: file #27554 replaces #27553

Michael Godfrey <godfrey>
Project Member
Sat 02 Mar 2013 11:30:26 PM UTC, comment #1:

Minor typo in patch, correction below.
Sorry,
Michael

(file #27554)

Michael Godfrey <godfrey>
Project Member
Sat 02 Mar 2013 11:11:56 PM UTC, original submission:

After several interchanges with Rik I and he have implemented
many enhancements and corrections to stemleaf.

I have also included in this patch minor changes to printd
which improve the documentation and prevent the tests
for printd from writing output.

Michael Godfrey <godfrey>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27554:  stemleaf_printd.diff added by godfrey (33KiB - text/x-patch)
file #27553:  stemleaf_printd.diff added by godfrey (33KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by godfrey (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 03 Mar 2013 02:55:48 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 02 Mar 2013 11:30:26 PM UTCgodfreyAttached File-=>Added stemleaf_printd.diff, #27554
    Sat 02 Mar 2013 11:11:56 PM UTCgodfreyAttached File-=>Added stemleaf_printd.diff, #27553

    Back to the top


    Powered by Savane 3.1-cleanup1