bugGNU Octave - Bugs: bug #38435, delete.m "max recursion depth...

 
 

bug #38435: delete.m "max recursion depth exceeded" in windows 1.2.0 package

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Wed 27 Feb 2013 11:13:01 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: 3.6.2Operating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 01 Mar 2013 03:02:48 PM UTC, comment #9:

Fixed by:

http://sourceforge.net/p/octave/code/11673/

Thanks for testing.

Michael Goffioul <goffioul>
Project Member
Fri 01 Mar 2013 02:54:13 PM UTC, comment #8:

Fixed package windows-1.2.1.tar.gz works OK.

Thanks for fixing!

Philip Nienhuis <philipnienhuis>
Project Member
Thu 28 Feb 2013 10:52:43 PM UTC, comment #7:

Would you mind testing this fixed package, before I make a new release?

(file #27550)

Michael Goffioul <goffioul>
Project Member
Thu 28 Feb 2013 10:45:25 PM UTC, comment #6:

That's because com_delete doesn't return any value, so octave cannot do the assignment: output = <empty>.

It's a copy-n-paste error.

I'm glad you tested it...

Michael Goffioul <goffioul>
Project Member
Thu 28 Feb 2013 10:39:41 PM UTC, comment #5:

If in share\octave\packages\windows-1.2.0\@octave_com_object\delete.m the line:

is replaced by a simple

it all works OK, both in 3.6.x and in (MXE compiled) 3.7.2+
I do not understand why, but it works. I also do not understand why "output = " LHS apparently doesn't harm in the other functions in .\@octave_com_object\

The Java message below is a red herring, it was just a next statement in one of the io functions. The COM error occurred in a try-catch.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 28 Feb 2013 09:45:15 AM UTC, comment #4:

BTW this was in Octave-3.6.2_MinGW w separate OF Java package.

Any reason to suspect that windows-1.2.0 will work better in 3.7.1+ w integrated Java?

Philip Nienhuis <philipnienhuis>
Project Member
Thu 28 Feb 2013 07:11:59 AM UTC, comment #3:

Heh... I could (should) have seen that myself (if it wasn't after midnight :-) )

Fixing that helps a bit.
But then I get:

Adding in a "keyboard and stepping gives:

So there we go..... interference with the Java class helpers.... :-(

Philip Nienhuis <philipnienhuis>
Project Member
Wed 27 Feb 2013 11:16:20 PM UTC, comment #2:

Stupid error on my side, @octave_com_object/delete.m calls itself instead of calling com_delete().

Michael Goffioul <goffioul>
Project Member
Wed 27 Feb 2013 11:15:08 PM UTC, comment #1:

(Interesting.... the "verbatim" stuff in the Octave bug tracker seems to eat single backslashes....)

Philip Nienhuis <philipnienhuis>
Project Member
Wed 27 Feb 2013 11:13:01 PM UTC, original submission:

The windows-1.2.0 package doesn't seem to correctly process the "delete" command with:
- Octave_3.6.2_gcc4.6.2 (MinGW)
- Octave-3.6.4_MXE

I can't test in Octave-3.6.2_MSVC2010 as I have no MSVC build tools.

With windows-1.1.0 all works correctly (apart from "dispatch is deprecated" complaints), both in MinGW and MXE builds.

Commenting out the offending "delete" lines in the relevant io package functions lines makes windows-1.2.0 work OK, but AFAIK "delete (<COM object>)" should just work, no?
After all it's largely the same code as in the mat2xls.m file in the windows-1.2.0/examples subdir.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27550:  windows-1.2.1.tar.gz added by goffioul (53KiB - application/x-gzip - Fixed package)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goffioul (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  • -unavailable- added by philipnienhuis
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 01 Mar 2013 03:02:48 PM UTCgoffioulStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Thu 28 Feb 2013 10:52:43 PM UTCgoffioulAttached File-=>Added windows-1.2.1.tar.gz, #27550
    Wed 27 Feb 2013 11:13:01 PM UTCphilipnienhuisCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1