bugGnash - The GNU Flash player - Bugs: bug #38419, $(realpath ...) doesn't recover...

 
 

bug #38419: $(realpath ...) doesn't recover from signals

Submitter:  None
Submitted:  Tue 26 Feb 2013 10:20:08 PM UTC
   
 
Category:  None Severity:  3 - Normal
Release:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 26 Feb 2013 10:20:08 PM UTC, original submission:  

func_realpath doesn't check errno at all.  When running in parallel builds, if the parent gmake process receives a signal in the middle of calling `realpath` it'll act as though the file does not exist.

Suggested fix:


2028c2017
<  while ( errno == EINTR || (path = find_next_token (&p, &len)) != 0)
---

>  while ( (path = find_next_token (&p, &len)) != 0)



The above use of || will shortcut and prevent it from pre-maturely grabbing the next token.

I haven't evaluated this to see if something more comprehensive could/should be done (eg, checking other "errno" values, etc).

I haven't finished validating whether this completely resolves the problem, but so far it seems to have done just that.  Furthermore, I don't have any ideas for how to implement a test for this as it's a race condition that isn't necessarily easy to reproduce.

I highly recommend evaluating other system functions used by gmake to determine whether this sort of issue could crop up elsewhere (eg, `$(abspath ...)`, etc)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

No changes have been made to this item

Back to the top

Powered by Savane 3.13-cf05.
Corresponding source code