(
Jump to the original submission)
Sat 23 Feb 2013 06:43:12 PM UTC, comment #8:
I reformatted your commit message to word-wrap at 80 columns and I rebased it:
http://hg.savannah.gnu.org/hgweb/octave/graph/c81b4c81339f
You may wish to remove your local copy of this commit with
|
Sat 23 Feb 2013 12:34:05 PM UTC, comment #7:
The new test classes added by the patch are missing from test/classes/module.mk. Here is a patch to fix this:
(file #27510)
|
Thu 21 Feb 2013 08:02:56 AM UTC, comment #6:
Great. Could you please close patch #7946 ?
https://savannah.gnu.org/patch/?7946
|
Wed 20 Feb 2013 08:43:43 PM UTC, comment #5:
I have applied your patch, along with minor whitespace style fixes:
http://hg.savannah.gnu.org/hgweb/octave/graph/ac672925fc98
Thanks.
|
Sun 10 Feb 2013 10:33:46 AM UTC, comment #4:
I have rebased the patch to cset:999f8257313b (test_classes.m renamed to classes.tst) and run a full "make check". Everything still looks ok.
(file #27437)
|
Sat 09 Feb 2013 05:48:22 PM UTC, comment #3:
A file was missing from the patch, here it is.
(file #27427)
|
Sat 09 Feb 2013 01:00:53 PM UTC, comment #2:
The attached patch fixes the bugs in inferiorto().
Several other functions related to class precedence are rewritten for clarity, and tests are added to test/classes/test_classes.m.
[Note: this was initially submitted as patch #7946]
(file #27426)
|
Sat 09 Feb 2013 10:28:17 AM UTC, comment #1:
I meant "doesn'T behave as expected" and "fails silentLy"... The worse part is, I actually proofread my post before sending... Is there any way I can correct my post after sending it ?
|
Sat 09 Feb 2013 10:25:21 AM UTC, original submission:
The attached tests exhibit two bugs in inferiorto().
First bug: calling inferiorto() when the opposite precendence is already set fails silenty (neither does it generate an error, as expected, nor does it actually change the precedence relationship).
Second bug: calling inferiorto() when no precedence is already set generates an undue error.
Both are actually related to the same error in the C++ code. A patch with bugfix & tests will follow shortly.
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 7 latest changes.
| Date |
Changed By |
Updated Field |
Previous Value |
=> |
Replaced By |
| Sat 23 Feb 2013 12:34:05 PM UTC | jbect | Attached File | - |  | Added jbFixTestClassesModuleDotMk.patch, #27510 |
| Wed 20 Feb 2013 08:43:43 PM UTC | jordigh | Status | None |  | Fixed |
| | | Open/Closed | Open |  | Closed |
| Sun 10 Feb 2013 10:33:46 AM UTC | jbect | Attached File | - |  | Added jbFixPrecedenceBug7.patch, #27437 |
| Sat 09 Feb 2013 05:48:22 PM UTC | jbect | Attached File | - |  | Added jbFixPrecedenceBug5.patch, #27427 |
| Sat 09 Feb 2013 01:00:53 PM UTC | jbect | Attached File | - |  | Added jbFixPrecedenceBug4.patch, #27426 |
| Sat 09 Feb 2013 10:25:21 AM UTC | jbect | Attached File | - |  | Added showPrecedenceBugs.zip, #27425 |