bugGNUstep - Bugs: bug #37939, NSNetService simple boolean logic...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37939: NSNetService simple boolean logic bug

Submitted by:  Marcus Müller <znek>
Submitted on:  Sun 16 Dec 2012 08:51:54 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Tue 18 Dec 2012 09:19:46 AM UTC, comment #1:

Thanks ... I applied your fix.

Richard Frith-Macdonald <CaS>
Project Member
Sun 16 Dec 2012 08:51:54 PM UTC, original submission:

-[NSNetService getInputStream:outputStream] accidentaly fails if either inputStream or outputStream pointer parameters are NULL (which is legal for either one).

The fix is simple:

Index: Source/NSNetServices.m
===================================================================
--- Source/NSNetServices.m (revision 35898)
+++ Source/NSNetServices.m (working copy)
@@ -281,7 +281,7 @@
inputStream: inputStream
outputStream: outputStream];

- return inputStream && outputStream;
+ return inputStream || outputStream;
}

/*

Marcus Müller <znek>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by znek (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 18 Dec 2012 09:19:46 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1