bugCompact Disc Input and Control Library - Bugs: bug #37447, native paths for some tests

 
 

bug #37447: native paths for some tests

Submitted by:  -Deleted Account- <lrn>
Submitted on:  Wed 26 Sep 2012 06:18:36 PM UTC  
 
Category: regression testsSeverity: 5 - Average
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 02 Oct 2012 02:13:25 AM UTC, comment #7:

Glad to here this has worked out!

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Thu 27 Sep 2012 01:40:16 PM UTC, comment #6:

At last, after all my years of searching... the Cave of Wonders!

That is, it works. Without patching.

-Deleted Account- <lrn>
Thu 27 Sep 2012 11:12:26 AM UTC, comment #5:

Try commit 64577fb .

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Thu 27 Sep 2012 05:09:00 AM UTC, comment #4:

Here are parts of the log that show why it doesn't work either :)

(and no, i don't know where version.texi was created, if it was at all)

(file #26655, file #26656, file #26657)

-Deleted Account- <lrn>
Thu 27 Sep 2012 03:16:29 AM UTC, comment #3:

Commit 66a42ea limits changing native paths to srcdir and abs_top_srcdir on MinGW.

sh.exe is wrong because pwd -W is a bash builtin. It is not in for example dash or ash and dash is a suitable alternative in MinGW.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Thu 27 Sep 2012 02:41:15 AM UTC, comment #2:

1) I would advise to use sh.exe, not bash.exe (although i'm not sure if other shells support the -W argument to pwd builtin...), since sh is provided by many shells, while bash - only by bash itself.

2) No, it doesn't work. I get this:
make[3]: *** No rule to make target `F:/sbuild.bak.6/src/mingw/libcdio-git-f3cdade5c87aab6fd30e95487da75d713b5fb728-1/libcdio-f3cdade5c87aab6fd30e95487da75d713b5fb728/example/extract.exe', needed by `check_udf.sh'.

And indeed, looking at generated test/Makefile i see:

abs_builddir = F:/sbuild.bak.6/src/mingw/libcdio-git-f3cdade5c87aab6fd30e95487da75d713b5fb728-1/libcdio-f3cdade5c87aab6fd30e95487da75d713b5fb728/test
abs_srcdir = /src/mingw/libcdio-git-f3cdade5c87aab6fd30e95487da75d713b5fb728-1/libcdio-f3cdade5c87aab6fd30e95487da75d713b5fb728/test
abs_top_builddir = F:/sbuild.bak.6/src/mingw/libcdio-git-f3cdade5c87aab6fd30e95487da75d713b5fb728-1/libcdio-f3cdade5c87aab6fd30e95487da75d713b5fb728
abs_top_srcdir = /src/mingw/libcdio-git-f3cdade5c87aab6fd30e95487da75d713b5fb728-1/libcdio-f3cdade5c87aab6fd30e95487da75d713b5fb728

to make it clear, the actual builddirectory is this:
F:/sbuild.bak.6/src/mingw/libcdio-git-f3cdade5c87aab6fd30e95487da75d713b5fb728-1/bld

That is, with your change buildsystem confuses srcdir and builddir.

-Deleted Account- <lrn>
Thu 27 Sep 2012 12:37:02 AM UTC, comment #1:

Commit f3cdade is a less obtrusive and more specific version.

See if this addresses this issue.

It could fail on MinGW if /bin/bash.exe is not installed, but I'll we will cross that bridge when someone gets to it.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Wed 26 Sep 2012 06:18:36 PM UTC, original submission:

Testsuite pre-processes some source files, hardcoding data file paths into them. That is bad, because MSys name mangling doesn't come into play, and testcases fail to find files at runtime.

I have a patch that seems to be fixing this for me. Please see if it doesn't mess up non-W32 systems.

I'll attach a fresh logfile to https://savannah.gnu.org/bugs/index.php?37394 , it's made with this patch.

-Deleted Account- <lrn>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26655:  version_texi_was.log added by lrn (3KiB - application/octet-stream)
file #26656:  version_texi_is.log added by lrn (3KiB - application/octet-stream)
file #26657:  version_texi.diff added by lrn (6KiB - application/octet-stream)
file #26649:  0008-fix-native-paths.all.patch added by lrn (3KiB - text/x-diff - Hardcodes native paths into testcases.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by lrn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 02 Oct 2012 02:13:25 AM UTCrockyStatusNone=>Fixed
      Assigned toNone=>rocky
      Open/ClosedOpen=>Closed
    Thu 27 Sep 2012 05:09:00 AM UTClrnAttached File-=>Added version_texi_was.log, #26655
      Attached File-=>Added version_texi_is.log, #26656
      Attached File-=>Added version_texi.diff, #26657
    Wed 26 Sep 2012 06:18:36 PM UTClrnAttached File-=>Added 0008-fix-native-paths.all.patch, #26649

    Back to the top


    Powered by Savane 3.1-cleanup1