bugGNU source-highlight - Bugs: bug #36860, --version 3.1.4 (tcl.lang):...

 
 

bug #36860: --version 3.1.4 (tcl.lang): ${name} variables are not highlighted

Submitted by:  Martin Heinrich <heinrichmartin>
Submitted on:  Tue 17 Jul 2012 12:20:18 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Lorenzo Bettini <bettini>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 09 Nov 2012 03:13:21 PM UTC, comment #5:

fixed in git head

Lorenzo Bettini <bettini>
Project AdministratorIn charge of this item.
Thu 19 Jul 2012 12:00:33 PM UTC, comment #4:

Thank you for the fixes :)

could you also please write some tcl lines of code that I can put in the test suite for the new features?

Lorenzo Bettini <bettini>
Project AdministratorIn charge of this item.
Thu 19 Jul 2012 10:35:59 AM UTC, comment #3:

Hi,
sorry for the bad formatting, I always notice after submitting the comment...

One more thing is in the patch. <pre>vardef ID = '[[:word:]:-]+'</pre>

And now I added even more for TCL:
<pre>
(keyword,normal,variable) = `(set|variable|global)([[:blank:]]+)([[:word:]:-]+)`
</pre>
I did not find a way to include $ID in this kind of notation...

Thanks for the fixes! It's always good to know, that projects are alive :-)

Martin Heinrich <heinrichmartin>
Thu 19 Jul 2012 08:07:43 AM UTC, comment #2:

Hi
the patch is badly formatted, but from what I understand it is enough to use

variable = "$" + $ID + "|${" + $ID + "}"

am I right?
I pushed this change to master (and updated the test), so I guess we can consider this as fixed

Lorenzo Bettini <bettini>
Project AdministratorIn charge of this item.
Tue 17 Jul 2012 12:52:22 PM UTC, comment #1:

I will try with these changes (including keywords for expect):

1a2

> # extended for expect, by heinrichmartin

19c20
< "append|binary|format|re_syntax|regexp|regsub",
---

> "append|binary|format|re_syntax|regexp|regsub",

27c28
< "load|loadTk|package|pgk::create|pgk_mkIndex|source",
---

> "load|loadTk|package|pkg::create|pkg_mkIndex|source",

33c34,40
< vardef ID = '[[:word:]]+'
---

> keyword = "close|debug|disconnect|exit|exp_continue|exp_internal",
> "exp_open|exp_pid|exp_send|exp_send_error|exp_send_log",
> "exp_send_tty|exp_send_user|exp_version|expect|expect_after",
> "expect_before|expect_tty|expect_user|fork|interact",
> "interpreter|log_file|log_user|match_max|overlay|parity",
> "remove_nulls|send|send_error|send_log|send_tty|send_user",
> "sleep|spawn|strace|stty|system|timestamp|trap|wait"

35c42,44
< variable = '\$' + $ID
\ No newline at end of file
---

> vardef ID = '[[:word:]:-]+'
>
> variable = "$" + $ID + "|${" + $ID + "}"

Martin Heinrich <heinrichmartin>
Tue 17 Jul 2012 12:20:18 PM UTC, original submission:

TCL allows embraced variable names as in ${var}. These are not highlighted.

Martin Heinrich <heinrichmartin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26224:  tmp.tcl added by heinrichmartin (693B - application/octet-stream - some Tcl code; a few fixes are not yet available...)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bettini (Posted a comment)
  • -unavailable- added by heinrichmartin (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 09 Nov 2012 03:13:21 PM UTCbettiniStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Thu 19 Jul 2012 02:29:01 PM UTCheinrichmartinAttached File-=>Added tmp.tcl, #26224
    Thu 19 Jul 2012 12:00:43 PM UTCbettiniStatusFixed=>In Progress
    Thu 19 Jul 2012 08:07:43 AM UTCbettiniStatusNone=>Fixed
      Assigned toNone=>bettini

    Back to the top


    Powered by Savane 3.1-cleanup1