bugGNU Octave - Bugs: bug #36819, strread.m: bit width and %[] and...

 
 

bug #36819: strread.m: bit width and %[] and %q format conversion specifiers (bug #33875)

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Mon 09 Jul 2012 08:24:36 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Matlab Compatibility
Status: NoneAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Any

Discussion locked!

 

Thu 12 Jul 2012 07:08:50 PM UTC, comment #5:

That was my idea in the first place, before I chose the wrong tracker.
I'll move the patches to the patch tracker later tonight.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 12 Jul 2012 03:55:33 PM UTC, comment #4:

We can do whatever we want with the bug report. My thinking is that we would leave the patches on the patch tracker for "eternity", but close this bug report.

Rik <rik5>
Project Administrator
Wed 11 Jul 2012 06:10:59 PM UTC, comment #3:

Patch tracker would be best.
Can this "bug" be deleted then? or does it stay here for eternity?

Philip Nienhuis <philipnienhuis>
Project Member
Wed 11 Jul 2012 03:37:43 PM UTC, comment #2:

Philip, do you want to re-submit these patches to the patch tracker and then close this bug report? Or do you want to leave them here? If so, for how long?

Rik <rik5>
Project Administrator
Tue 10 Jul 2012 09:40:47 PM UTC, comment #1:

Sorry I s****d up a bit.
Should have sent it to the patch tracker.

Philip Nienhuis <philipnienhuis>
Project Member
Mon 09 Jul 2012 08:24:36 PM UTC, original submission:

A while ago I've implemented bit width format conversion specifiers (%d8, %u64, etc) to strread.m; as strread.m currently is the work horse for textscan.m, they now also work in textscan.m
AFAICS these changes seem to work fairly reliably. Patch including some tests attached.

I've also implemented %[] (and %[], %[^..], %[^..]) plus %q specifiers in strread.m (so these will work in textscan, too), but these changes don't work so very reliably. That is, they do, as long as whitespace and/or delimiters are not contained in words matching the %q and %[]-like specifiers. In the tests you can see that in columns matching %[] or %q specifiers the same number of whitespace/delimiters must be present on each line, otherwise strread.m quickly loses track.
For my own (simple) purposes it worked OK up till now, but that's no guarantee.

As advised by Rik I don't develop these patches any further.
I contribute them here just for in case other people want to have a try.
For convenience I've also attached patched strread.m versions in a tarball ( md5sum: 5294a30679a2f6c633f110792da611b7 )

Philip Nienhuis <philipnienhuis>
Project Member

 

Attached Files
file #26171:  strread_bitwidth.patch added by philipnienhuis (9KiB - application/x-download)
file #26172:  strread_bitwidth_regexp.patch added by philipnienhuis (29KiB - application/x-download)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 12 Jul 2012 07:08:50 PM UTCphilipnienhuisStatusPatch Submitted=>None
      Open/ClosedOpen=>Closed
      Discussion LockUnlocked=>Locked
    Mon 09 Jul 2012 08:24:36 PM UTCphilipnienhuisAttached File-=>Added strread_bitwidth.patch, #26171
      Attached File-=>Added strread_bitwidth_regexp.patch, #26172
      Attached File-=>Added strread_bitwidth_regexp.tar.gz, #26173

    Back to the top


    Powered by Savane 3.1-cleanup1