bugGNU Octave - Bugs: bug #36777, possible typo in CMatrix.h

 
 

bug #36777: possible typo in CMatrix.h

Submitted by:  CarnĂ« Draug <carandraug>
Submitted on:  Tue 03 Jul 2012 02:41:26 PM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: InvalidAssigned to: None
Originator Name: brownalexOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 04 Jul 2012 01:06:26 AM UTC, comment #2:

I don't think this is a bug.

If you look at dag in Array.cc, you'll see that it can do two different things:

1. extract a diagonal from a matrix.

2. create a matrix with a given diagonal.

So the return type must be a matrix, not a vector.

John W. Eaton <jwe>
Project Administrator
Tue 03 Jul 2012 04:57:11 PM UTC, comment #1:

I would take this up on the Octave-Maintainer's list. As you say, the issue also affects ordinary double matrices (dMatrix.h) and it might be easier to take up the issue with that fundamental class first. Incidentally, I just tried changing the prototype in dMatrix.h to ColumnVector and changing the equivalent function in dMatrix.cc to match and Octave doesn't compile. So, there is some reason why it is Matrix and not ColumnVector.

Rik <rik5>
Project Administrator
Tue 03 Jul 2012 02:41:26 PM UTC, original submission:

Hi

on September last year, the following was reported on the octave-forge forums (which have since been made invisible since no one was following them):

From my understanding of the functions in the header file CMatrix.h, the diag function is meant to extract the diagonal elements of a ComplexMatrix and return them as a
ComplexColumnVector, however, the function has the prototype:

rather than

as it should. The ordinary matrices also have this problem.

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  • -unavailable- added by carandraug (Sf e-mail from reported)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 06 Jul 2012 05:23:32 AM UTCrik5StatusNone=>Invalid
      Open/ClosedOpen=>Closed
    Tue 03 Jul 2012 02:41:26 PM UTCcarandraugCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1