bugGNU Octave - Bugs: bug #36717, Fix curl_handle::curl_handle_rep...

 
 

bug #36717: Fix curl_handle::curl_handle_rep to keep a copy of string parameters passed to cURL

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Sun 24 Jun 2012 04:56:22 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 07 Sep 2012 11:26:11 PM UTC, comment #1:

Fixed with this changeset:
http://hg.savannah.gnu.org/hgweb/octave/rev/81fe6665ed3c

Mike Miller <mtmiller>
Project Administrator
Sun 24 Jun 2012 04:56:22 PM UTC, original submission:

The cURL library changed the curl_easy_setopt call to make an internal copy of string parameters in version 7.17.0. Prior versions only held a pointer to a string provided by the caller that must persist for the lifetime of the CURL handle.

The associated API did not change, only the behavior of the library implementing the function call.

To be compatible with any version of cURL, the caller must keep a copy of all string parameters associated with a CURL handle until the handle is released. The curl_handle::curl_handle_rep class contains the pointer to the CURL handle and so is the best candidate for storing the strings as well.

Maybe implement this with a new macro

The string options affected are CURLOPT_URL (failure observed) and CURLOPT_USERPWD (likely, not yet observed).

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 07 Sep 2012 11:26:11 PM UTCmtmillerStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1