bugGNU Octave - Bugs: bug #36665, ppval fails when pp.dim > 1 and...

 
 

bug #36665: ppval fails when pp.dim > 1 and xi is an array

Submitted by:  Marco Caliari <caliari>
Submitted on:  Fri 15 Jun 2012 07:18:03 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Marco Caliari <caliari>
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 03 Jul 2012 03:51:37 PM UTC, comment #7:

Okay, I went ahead and made the small tweak. Closing this report.

Rik <rik5>
Project Administrator
Mon 02 Jul 2012 10:16:32 PM UTC, comment #6:

Rik,

Looks good to me. Marco's patch has already been pushed. If you'd like me to push your change ... say the word.

Ben

Ben Abbott <bpabbott>
Project Member
Mon 02 Jul 2012 05:23:04 PM UTC, comment #5:

Just a small efficiency question.

In the patch, a column vector is created using the (:) syntax. This is then tiled up using repmat to a larger array using repmat ([1, prod(d)]). Finally, a transpose of the matrix is performed to turn the multiple column vectors into row vectors.

Transpose is very fast. Still, wouldn't it be more efficient to transpose the smaller object, the column vector, rather than the larger object, the complete matrix?

Rik <rik5>
Project Administrator
Mon 02 Jul 2012 12:08:01 PM UTC, comment #4:

Marco,

I pushed your changeset. I ran the integrated tests and all passed.

http://hg.savannah.gnu.org/hgweb/octave/rev/e437bacb3ef6

Ben Abbott <bpabbott>
Project Member
Mon 02 Jul 2012 08:50:26 AM UTC, comment #3:

For some reason I can't push. Attached is my changeset.

Marco

(file #26135)

Marco Caliari <caliari>
Project MemberIn charge of this item.
Fri 29 Jun 2012 06:35:49 PM UTC, comment #2:

This looks sound. Please make a changeset.

Rik <rik5>
Project Administrator
Sat 16 Jun 2012 11:49:55 PM UTC, comment #1:

Marco,

Matlab behaves as you suggest.

I didn't study how ppval works in detail, but it looks to me as if you have interpreted it correctly.

Ben Abbott <bpabbott>
Project Member
Fri 15 Jun 2012 07:18:03 AM UTC, original submission:

Dear all,

consider the following

whereas

I think that ans(:,:,1) and ans(:,:,2) should be both equal to the previous result (as in ml). I got the correct answer by replacing

with

If you confirm this is the proper fix, I can submit a changeset.

Marco

Marco Caliari <caliari>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26135:  ppval.diff added by caliari (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by bpabbott (Posted a comment)
  • -unavailable- added by caliari (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 03 Jul 2012 03:51:37 PM UTCrik5StatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 02 Jul 2012 12:08:01 PM UTCbpabbottStatusConfirmed=>Ready For Test
      Release3.6.0=>dev
    Mon 02 Jul 2012 08:50:26 AM UTCcaliariAttached File-=>Added ppval.diff, #26135
    Fri 29 Jun 2012 08:14:19 PM UTCbpabbottAssigned toNone=>caliari
    Fri 29 Jun 2012 06:35:49 PM UTCrik5Summaryppval fails when pp.dim > 1 ans xi is an array=>ppval fails when pp.dim > 1 and xi is an array
    Sat 16 Jun 2012 11:49:55 PM UTCbpabbottStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1