bugGNU Octave - Bugs: bug #36469, pkg load can't deal with circular...

 
 

bug #36469: pkg load can't deal with circular dependencies

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Mon 14 May 2012 10:06:20 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: Mike Miller <mtmiller>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 21 May 2012 11:32:47 AM UTC, comment #3:

Sorry for taking so long to test this change. It indeed solves the problem. Thank you

When testing this I noticed another bug on the pkg system when unloading packages. Packages that are dependent on the package being unloaded are not unloaded and no warning is given. I'll open a separate bug report for that.

Carnë Draug <carandraug>
Project Member
Sat 19 May 2012 03:40:56 PM UTC, comment #2:

Ok, I pushed this after getting some time to test a few cases. This feature will be available in Octave 3.8.x.

http://hg.savannah.gnu.org/hgweb/octave/rev/dee1452ca601

As a side effect, the path ordering between sibling dependencies of a package now matches the ordering in the package Depends line.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 17 May 2012 01:01:02 PM UTC, comment #1:

Can you try this patch and confirm that it works for your test cases?

(file #25872)

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 14 May 2012 10:06:20 PM UTC, original submission:

Hi

when there's 2 packages, each of them depending on each other, pkg load will enter into a recursive loop and give a max_recursion_depth exceeded error. pkg install does not have that problem (provided both packages are given at the time of installation).

Basically, if pkg1 and pkg2 depend on one another:

A temporary workaround for this is to load the packages with the -nodeps flag.

I'll have to look into this code better when I get time but I was thinking of looking into whatever pkg install is doing to solve the dependencies, and adapt it for pkg load.

Carnë

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 May 2012 03:40:56 PM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
      Release3.6.1=>dev
    Thu 17 May 2012 01:01:02 PM UTCmtmillerAttached File-=>Added pkg-load-circular-deps.patch, #25872
      StatusNone=>Patch Submitted
      Assigned toNone=>mtmiller

    Back to the top


    Powered by Savane 3.1-cleanup1