bugGNUstep - Bugs: bug #3637, EOAttribute components read in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #3637: EOAttribute components read in from file but not written out

Submitted by:  Dirk Lattermann <dlatt>
Submitted on:  Fri 16 May 2003 11:08:21 AM UTC  
 
Category: gdl2Severity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: David Ayers <ayers>
Open/Closed: Closed

Fri 16 May 2003 08:22:58 PM UTC, comment #4:

OK, verified with WO4.5...

  • EOAccess/EOAttribute.m ([EOAttribute -encodeIntoPropertyList:]):

Encode missing aattributes as reported by Dirk Lattermann. Also
corrected encoding of parameterDirection.
([EOAttribute initWithPropertyList:owner:]): Corrected parsing of
parameterDirection to account for WO 4.5 compatibility and
previous encodings.

Commited.

Thanks again!

David Ayers <ayers>
Project MemberIn charge of this item.
Fri 16 May 2003 05:23:07 PM UTC, comment #3:

OK, I'm not sure when I'll be able to verify the actual format of parameterDirection on WO 4.5's .storedProcedure format. But for now, I've uploaded a patch that fixes these issues, writes parameterDirection in the format of EOF of OS 4.2 yet parses both formats. I'll commit it to cvs once I've verified it.

David Ayers <ayers>
Project MemberIn charge of this item.
Fri 16 May 2003 02:49:35 PM UTC, comment #2:

Almost have it...
Yet for parameterDirection GDL2 currently parses the strings @"in" @"out" @"inout" from a .storedProcedure file while the EOModeler of OS 4.2 writes the enum values 1 2 3 into the property list. If someone could tell me what EOModeler of WO 4.5 does for stored procedure attributes, I can quickly finish the patch. Otherwise I'll post a prelimanary patch, until I can find time to see what WO 4.5 actually writes into the model.

David Ayers <ayers>
Project MemberIn charge of this item.
Fri 16 May 2003 01:09:53 PM UTC, comment #1:

Thanks!

updateFormat and insertFormat have been superseded by writeFromat as selectFormat has been superseded by readFormat. So we don't want to write models using the old names. And when we read the old ones we put them in the new place. I'm not sure about internalInfo but it shouldn't hurt, so unless someone objects, I'll also write it. The others will be included in a bug fix I'm preparing.

David Ayers <ayers>
Project MemberIn charge of this item.
Fri 16 May 2003 11:08:21 AM UTC, original submission:

The following components of EOAttribute are set in initWithPropertyList:owner: (resp. awakeWithPropertyList:), but they are not written to a property list in encodeIntoPropertyList:.
Thus, they are read in from an eomodeld-file, but not written out:

allowsNull
updateFormat
insertFormat
selectFormat
width
valueFactoryMethodName
adaptorValueConversionMethodName
factoryMethodArgumentType
precision
scale
parameterDirection
internalInfo

(maybe only width, precision, scale and allowsNull are important enough to be included in a first bugfix?)

Dirk Lattermann <dlatt>

 

Attached Files
file #453:  gdl2.patch added by ayers (4KiB - application/octet-stream - preliminary patch for EOAttribute property list encoding)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 16 May 2003 08:22:58 PM UTCayersStatusNone=>(Error - Not Found)
  Open/ClosedOpen=>(Error - Not Found)
Fri 16 May 2003 01:09:53 PM UTCayersAssigned toNone=>NA

Back to the top


Powered by Savane 3.1-cleanup1