bugGNU Octave - Bugs: bug #36314, failing tests in data.cc

 
 

bug #36314: failing tests in data.cc

Submitted by:  Carlo de Falco <cdf>
Submitted on:  Thu 26 Apr 2012 10:09:09 AM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: John W. Eaton <jwe>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 10 May 2012 08:33:41 PM UTC, comment #10:

I checked in the following change:

http://hg.savannah.gnu.org/hgweb/octave/rev/13cc11418393

If you notice any new problems with incorrect filling on resizing, please open a new bug report.

John W. Eaton <jwe>
Project AdministratorIn charge of this item.
Fri 27 Apr 2012 05:28:21 AM UTC, comment #9:

I don't know why the push did not work anyway,
if it is not the correct fix I'm glad it didn't ;)
c.

Carlo de Falco <cdf>
Project Member
Fri 27 Apr 2012 01:39:56 AM UTC, comment #8:

It doesn't look like you actually pushed the changeset.

If you did not, please don't push it, because it is not the rigth fix. If you did push it, please undo it.

I have a fix for this problem, but it is not complete yet. I'll try to finish and push it soon. Sorry about the failing test.

John W. Eaton <jwe>
Project AdministratorIn charge of this item.
Thu 26 Apr 2012 03:11:14 PM UTC, comment #7:

OK, pushed.
c.

Carlo de Falco <cdf>
Project Member
Thu 26 Apr 2012 01:55:10 PM UTC, comment #6:

Looks like a bad merge, Carlo.

Push the fix. I was talking with jwe in #octave about this diagonal matrix problem. I guess something went wrong during the merge.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Thu 26 Apr 2012 12:48:09 PM UTC, comment #5:

Ben,

I don't understand the code myself either, I just noticed
that when transplanting the changeset from stable to default
only half of the patch went through.

As the change was done by JWE I'd rather wait for him to comment before pushing.

c.

Carlo de Falco <cdf>
Project Member
Thu 26 Apr 2012 11:59:42 AM UTC, comment #4:

The patch works for me.

I'm not familiar with this part of the code, so I'm hesitant to push.

Carlo, do you think it is safe to push?

Ben Abbott <bpabbott>
Project Member
Thu 26 Apr 2012 11:18:51 AM UTC, comment #3:

after more careful inspection I noticed that with

http://hg.savannah.gnu.org/hgweb/octave/rev/3a9a56999ce5

only part of the changes introduced in

http://hg.savannah.gnu.org/hgweb/octave/rev/5bb5fcffa29d

were transferred from stable to default:
the new tests were added to data.cc but the
rest of the modifications to handle cell array
args in diag were not.

the attached patch fixes the test failures for me.

(file #25742)

Carlo de Falco <cdf>
Project Member
Thu 26 Apr 2012 10:30:11 AM UTC, comment #2:

I see now that the tests were introduced with changeset 5bb5fcffa29d so I don't think this should be marked as a regression anymore.

Carlo de Falco <cdf>
Project Member
Thu 26 Apr 2012 10:26:19 AM UTC, comment #1:

oops, I referred to the wrong changeset, I have to roll-back to before

to make the failures go away.
Still, this changeset is just a merge of stable to default
so the responsible changeset is one of the previous ones committed to stable.

Carlo de Falco <cdf>
Project Member
Thu 26 Apr 2012 10:09:09 AM UTC, original submission:

With current HEAD I see the following test failures in data.cc
with "make check":

If I roll-back to before this changeset:

the same tests do not fail, therefore I am marking this as a regression.

Carlo de Falco <cdf>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25742:  open_nhXuXcOu.txt added by cdf (1KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by bpabbott (Posted a comment)
  • -unavailable- added by cdf (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 10 May 2012 08:33:41 PM UTCjweStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Fri 27 Apr 2012 01:39:56 AM UTCjweStatusPatch Submitted=>In Progress
      Assigned toNone=>jwe
      Open/ClosedClosed=>Open
    Thu 26 Apr 2012 03:11:21 PM UTCcdfOpen/ClosedOpen=>Closed
    Thu 26 Apr 2012 11:20:16 AM UTCcdfStatusNone=>Patch Submitted
      Operating SystemMac OS=>Any
    Thu 26 Apr 2012 11:18:51 AM UTCcdfAttached File-=>Added open_nhXuXcOu.txt, #25742
    Thu 26 Apr 2012 10:30:11 AM UTCcdfItem GroupRegression=>Incorrect Result

    Back to the top


    Powered by Savane 3.1-cleanup1