bugGNU Octave - Bugs: bug #36272, Windows icons not shown

 
 

bug #36272: Windows icons not shown

Submitter:  Israel Herraiz <herraiz>
Submitted:  Mon 23 Apr 2012 12:56:44 AM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  jacobdawid
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 24 Jun 2013 06:16:06 PM UTC, comment #3: 

Recent windows builds have icons as expected so this report is closed.

Torsten Lilge <ttl>
Group Member
Mon 07 May 2012 01:56:19 AM UTC, comment #2: 

Fair enough :).

I have never created "resources files", but I will have a look, and if I end up with such a file, will post it here.

Israel Herraiz <herraiz>
Mon 07 May 2012 01:01:51 AM UTC, comment #1: 

Hello Israel,

the proper way of compiling pictures and other media into a Qt program is to use Qt resources. This is why I won't apply the patch you suggested. After all, I will leave this bug report open since the problem still resides until a proper Qt resources file has been created.

Jacob Dawid <jacobdawid>
Mon 23 Apr 2012 12:56:44 AM UTC, original submission:  

In the OctaveGUI, the windows for the different MDI windows and the main window are not shown.

The icons are in PNG files in the sources directory, which are not installed in the system with the provided Makefiles. The patch has been obtained against the "gui" branch of the Hg repository.

As a workaround, I am attaching a patch that fixes this. The icons are converted to XPM, and then included at compile time in the sources as char strings. Thus, when the icons are created there is no need to have a file in the system installed with the rest of Octave.

Israel Herraiz <herraiz>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25714:  fix_icons.patch added by herraiz (213KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by herraiz (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-06-24 ttl StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2012-05-07 jacobdawid StatusNone In Progress
    2012-05-07 jacobdawid Assigned toNone jacobdawid
    2012-04-23 herraiz Attached File- Added fix_icons.patch, #25714

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code