buggnubg - Bugs: bug #36237, External interfaces crashes...

 
 

bug #36237: External interfaces crashes program when evaluating money sessions

Submitted by:  Guido Flohr <gflohr>
Submitted on:  Wed 18 Apr 2012 09:55:41 AM UTC  
 
Originator Name: Guido FlohrItem Group: Crash error
Category: OtherRelease: 0.90-devel
Privacy: PublicOperating System: All
OS Type: AnyProcessor Type: Any
Severity: 3 - NormalOpen/Closed: Closed
Assigned to: Michael Petch <mdpetch>Priority: 5 - Normal
Status: Fixed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 18 Apr 2012 03:36:29 PM UTC, comment #2:

I reviewed your patch, and yes money sessions are a match length of zero. I also consider your patch to approximate match length for lengths > MAXSCORE reasonable given the alternative is to confuse or crash GNUBG. I will commit the change. Thanks for the patch.

Michael Petch <mdpetch>
Project AdministratorIn charge of this item.
Wed 18 Apr 2012 09:57:43 AM UTC, comment #1:

In my patch, I set the match length to 0 for unlimited matches resp. money sessions. Is that correct?

Guido Flohr <gflohr>
Project Member
Wed 18 Apr 2012 09:55:41 AM UTC, original submission:

With CVS checkout from April 18th:

Sending a FIBS board state for an unlimited match to gnubg makes it crash with a segmentation fault. The same will most probably happen for any match length > MAXSCORE.

Reproducible for example with: board:You:guido:9999:0:0:0:-2:0:0:0:0:5:0:3:0:0:0:-5:5:0:0:0:-3:0:-5:0:0:0:0:2:0:-1:3:6:0:0:1:1:1:0:-1:1:25:0:0:0:0:0:2:0:0:0

Guido Flohr <gflohr>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25678:  fibs-unlimited.patch added by gflohr (2KiB - text/x-patch - Fix for segmentation fault on board states for money sessions)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mdpetch (Posted a comment)
  • -unavailable- added by gflohr (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Apr 2012 04:00:28 PM UTCmdpetchOpen/ClosedAccepted=>Closed
      StatusIn Progress=>Fixed
    Wed 18 Apr 2012 03:38:04 PM UTCmdpetchOpen/ClosedOpen=>Accepted
      Assigned toNone=>mdpetch
      StatusNone=>In Progress
    Wed 18 Apr 2012 09:56:39 AM UTCgflohrAttached File-=>Added fibs-unlimited.patch, #25678

    Back to the top


    Powered by Savane 3.1-cleanup1