bugXBoard - Bugs: bug #36228, reserved identifier violation

 
 

bug #36228: reserved identifier violation

Submitted by:  Markus Elfring <elfring>
Submitted on:  Tue 17 Apr 2012 06:30:16 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Jun 2012 06:31:41 PM UTC, comment #3:

Thanks for your source code adjustments.

I hope that a tool like "Coccinelle" will become able to perform a corresponding semantic grep to find such update candidates.

Markus Elfring <elfring>
Mon 28 May 2012 08:06:29 PM UTC, comment #2:

Changed this in master: renamed to XB. I also made the include guards names more consistent, e.g. XB_<filename>.

Same for variables I found with git grep " _[^(]".

Markus: is there an easy way to check the code for these compliance issues, e.g. something we can run over the code every now and then to find things like this?

Thanks for reporting this.

Arun Persaud <apersaud>
Project Administrator
Tue 17 Apr 2012 07:12:39 PM UTC, comment #1:

There are more update candidates like "_ListGame" and "_OPT" besides the include guards.

Markus Elfring <elfring>
Tue 17 Apr 2012 06:30:16 PM UTC, original submission:

I would like to point out that identifiers like "_BACKEND" and "[http://git.savannah.gnu.org/cgit/xboard.git/tree/xhistory.h?id=8e8f7200a0db9c816e5b508bc0cd377a393bda41#n23 _XHISTL_H" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

Markus Elfring <elfring>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by apersaud (Posted a comment)
  • -unavailable- added by elfring (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 29 Sep 2012 07:43:12 PM UTCapersaudStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 28 May 2012 08:06:29 PM UTCapersaudStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1