bugGNU Networking Utilities - Bugs: bug #35953, reserved identifier violation

 
 

bug #35953: reserved identifier violation

Submitted by:  Markus Elfring <elfring>
Submitted on:  Thu 22 Mar 2012 05:05:24 PM UTC  
 
Category:  None Severity:  2 - Minor
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  Alfred M. Szmidt <ams>
Open/Closed:  Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 26 Mar 2012 05:26:30 PM UTC, comment #4:

What a C++ compiler does is really of no concern to us, all those headers are private.

If you can show a system where this is a problem, then that would be interesting, but some of this has been in wide usage since ~90 and some dating back to the ~80s, on more platforms than I can recall.

Closing as won't fix. Thanks for your interest!

Alfred M. Szmidt <ams>
Project AdministratorIn charge of this item.
Mon 26 Mar 2012 11:07:07 AM UTC, comment #3:

The affected include guards might also be reused by C++ source files.

Are you interested that your own identifiers will become completely standard-compliant?

Markus Elfring <elfring>
Mon 26 Mar 2012 03:23:10 AM UTC, comment #2:

Marcus, thank you for your report.

If you've experienced a clash with some compiler with those specific identifiers then it would be useful to know what operating system, and C compiler you used. But if it is just some theoretical clash of reserved identifiers (ISO/IEC 9899:2011, $7.1.3), then we might fix it at some point but not now; though patches make life just a bit easier.

PS, You quoted C++ guidelines for a C project that does not follow CERT's guidelines.

Alfred M. Szmidt <ams>
Project AdministratorIn charge of this item.
Mon 26 Mar 2012 01:07:36 AM UTC, comment #1:

This person opening up this report seems to have a fascination this. See also https://savannah.gnu.org/bugs/?35952, https://savannah.gnu.org/bugs/?35953, https://savannah.gnu.org/bugs/?35938, https://savannah.gnu.org/bugs/?35748, and https://savannah.gnu.org/bugs/?35874 which all have the same title and seem to have been opened at about the same time.

It is possible to request and get a patch from the person for your specific situtation. But you might want to review it as our developers found the first patch a bit ugly. We did however accept with slight modification a second patch attempt.

Rocky Bernstein <rocky>
Thu 22 Mar 2012 05:05:24 PM UTC, original submission:

I suggest to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on source files.
Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:

This usage does not fit to the expected naming conventions of the C/C++ language standard.
I recommend to adjust your selection for unique names.

Markus Elfring <elfring>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ams (Posted a comment)
  • -email is unavailable- added by rocky (Posted a comment)
  • -email is unavailable- added by elfring (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-03-27 ams Assigned toNone => ams
    2012-03-26 ams Severity3 - Normal => 2 - Minor
        StatusNone => Wont Fix
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.3