bugGNU Anubis - Bugs: bug #35936, Completion of error handling

 
 

bug #35936: Completion of error handling

Submitted by:  Markus Elfring <elfring>
Submitted on:  Wed 21 Mar 2012 05:01:59 PM UTC  
 
Category: securitySeverity: 3 - Normal
Item Group: NoneStatus: Wont Fix
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 22 Mar 2012 10:27:39 AM UTC, comment #2:

I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?

How do you think about information from the article "Quality Matters #6: Exceptions for Practically-Unrecoverable Conditions" by Matthew Wilson?

Markus Elfring <elfring>
Thu 22 Mar 2012 06:49:33 AM UTC, comment #1:

The return code of waitpid is of no interest for exec_argv, so there is no use checking it. Ditto for fprintf in filelog: if it fails there's no way to inform user about it, short of aborting. Besides, if fprintf fails something has got out of whack so badly that I see no use in complaining about this.

Sergey Poznyakoff <gray>
Project Administrator
Wed 21 Mar 2012 05:01:59 PM UTC, original submission:

I have looked at a few source files for your current software. I have noticed that a few checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

Markus Elfring <elfring>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gray (Posted a comment)
  • -unavailable- added by elfring (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 22 Mar 2012 06:49:33 AM UTCgrayStatusNone=>Wont Fix
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1