bugGNUstep - Bugs: bug #35901, Border appearing around some...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35901: Border appearing around some windows...

Submitted by:  Gregory John Casamento <gcasa>
Submitted on:  Mon 19 Mar 2012 02:52:03 PM UTC  
 
Category: Gui/AppKitSeverity: 4 - Important
Item Group: BugStatus: Invalid
Privacy: PublicAssigned to: None
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Sun 06 May 2012 12:49:52 PM UTC, comment #6:

I am closing this bug as requested by the original author.

German, could you please file a new bug report for your problem, which seems to be completely unrelated to the original issue?

Fred Kiefer <FredKiefer>
Project Member
Sun 06 May 2012 05:23:20 AM UTC, comment #5:

However there are problems with in-window menu in some apps. See attached image of MyGL.app running on Xfce with Silver theme. At launch, the menu isn't displayed and an empty bar is displayed at bottom. You needs resize the window to display the menu.

(file #25798)

Germán Arias <espectador>
Sun 06 May 2012 01:16:09 AM UTC, comment #4:

The way to reproduce it was simply to start up any app. You would see the issue in any window belonging to the application. I was testing with Gorm and Ink.

As of now, however, I'm not seeing this issue anymore. Which makes me wonder if it was an issue with my configuration or something. I haven't seen it for a couple of weeks now. I don't know what changed to correct the issue. If it happens again it's okay to re-open this bug, but for now I think I will go ahead and close it unless an argument can be made to keep it open.

Gregory John Casamento <gcasa>
Project Administrator
Fri 04 May 2012 03:22:34 PM UTC, comment #3:

Greg, could you please provide information on how to reproduce this problem?

Which application are you using (gorm I presume), on what platform and with which window manager?

Most likely the code that computes the window border is incorrect for your window manager and we end up with space around the window neither used by the window manager nor by GNUstep.

Fred Kiefer <FredKiefer>
Project Member
Sun 08 Apr 2012 06:36:53 PM UTC, comment #2:

Eric, I don't wuite understand your argument here. I would not be too surprised to learn that we have a specific problem here, but you claim that the whole concept is broken and I don't see that.

Could it be that you missed the point that we also get back the real window size from X via events?

The functionality is what you describe, we need to set and get the actual window size from GNUstep allthough this gets managed by a window manager and things happen asynchoniously between these two.

Fred Kiefer <FredKiefer>
Project Member
Mon 19 Mar 2012 07:26:54 PM UTC, comment #1:

This is a deep flaw in the way styleoffsets work in back/x11...

Here's the rundown as far as I understand:

The ivar underlying -[NSWindow frame] is supposed to include the window border, so you can position a window with its frame perfectly aligned with the bottom-left corner of the screen by doing [window setFrame: NSMakeRect(0, 0, w, h)]. Problem is, x11 is not designed to let you do that - the frame is controlled by the window manager. You can see there's a potential race condition here: if the frame size is stored in the applications process as part of the window's frame var, but the actual frame size is determined by the window manager in another process, we have to be very careful that disagreements over the dimensions of the frame don't clobber the window contents size (as is happening here.)

In particular the calls to [self styleoffsets:] in XGServerWindow.m are certainly incorrect, because they make a call to the X server and mix those freshly returned values with the NSWindow's frame.

The code needs to be redesigned so that the content size of a window can never be messed up.

Eric Wasylishen <ericw>
Project Member
Mon 19 Mar 2012 02:52:03 PM UTC, original submission:

For some reason I am seeing a black border around some windows, please see attached.

GC

Gregory John Casamento <gcasa>
Project Administrator

 

Attached Files
file #25798:  capturaMyGL.jpg added by espectador (78KiB - image/jpeg - MyGL.app running in Xfce with Silver theme)
file #25405:  border_issue.tiff added by gcasa (36KiB - image/tiff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by espectador (Updated the item)
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by ericw (Posted a comment)
  • -unavailable- added by gcasa (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 06 May 2012 12:49:52 PM UTCFredKieferStatusNone=>Invalid
      Open/ClosedOpen=>Closed
    Sun 06 May 2012 05:23:20 AM UTCespectadorAttached File-=>Added capturaMyGL.jpg, #25798
    Mon 19 Mar 2012 02:52:47 PM UTCgcasaCategoryNone=>Gui/AppKit
      Severity3 - Normal=>4 - Important
      Item GroupNone=>Bug
    Mon 19 Mar 2012 02:52:03 PM UTCgcasaAttached File-=>Added border_issue.tiff, #25405

    Back to the top


    Powered by Savane 3.1-cleanup1