bugPSPP - Bugs: bug #35887, Sort functionality preallocates...

 
 

bug #35887: Sort functionality preallocates excessive memory

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sun 18 Mar 2012 05:24:49 PM UTC  
 
Category: OtherSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 19 Mar 2012 04:43:13 AM UTC, comment #1:

> The sort code should allocate memory as actually needed, not all in advance.


I pushed commit c13310dc3f (sort: Allocate space for sort buffers on demand, not in advance.) to fix this.

Ben Pfaff <blp>
Project Administrator
Sun 18 Mar 2012 05:24:49 PM UTC, original submission:

John Darrington writes:

> The partcular problem I encountered stems from the fact, that
> for every category, I'm calling sort_create_writer, which in
> turn allocates space for a large number of cases - even if they
> are never used. I think I can solve that problem by sorting
> the cases before categorising. But I'm wondering if similar
> situations will arise where such an optimisation cannot be
> done.


This is excessive. The sort code should allocate memory as actually needed, not all in advance.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 19 Mar 2012 04:43:13 AM UTCblpStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1