bugGNUstep - Bugs: bug #35867, The NSFileManager's inconsistent...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35867: The NSFileManager's inconsistent manner of returning errors

Submitted by:  Sergei Golovin <svg>
Submitted on:  Sat 17 Mar 2012 07:11:52 AM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Sun 08 Jul 2012 03:57:12 PM UTC, comment #1:

Thanks, I applied changes based on your ideas.

Richard Frith-Macdonald <CaS>
Project Member
Sat 17 Mar 2012 07:11:52 AM UTC, original submission:

I stuck once more with the issues like the one reported within
#35692. Some methods with the **NSError as an argument for to
populate it in the case of a fail leave this argument intact on
an error.

If I get it correctly there is the instance variable _lastError
for the case when one of NSFileManager's conditions checks fails
and there is no related failed calls to a system library (so the
call [NSError _last] does not make sense for getting NSError
object). The variable isn't used in the current code besides
assigning. I utilize it by the patch to get the arguments
**NSError consistently populated either by use of the value
_lastError or by calling [NSError _last].
Also there is another patch adding more tests for that.

Sergei Golovin <svg>

 

Attached Files
file #25378:  gs_base_nsfilemanager.patch added by svg (10KiB - text/x-patch - The patches)
file #25379:  gs_base_Tests_Base_NSFileManager.patch added by svg (8KiB - text/x-patch - The patches)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by svg (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Jul 2012 03:57:12 PM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 17 Mar 2012 07:11:52 AM UTCsvgAttached File-=>Added gs_base_nsfilemanager.patch, #25378
      Attached File-=>Added gs_base_Tests_Base_NSFileManager.patch, #25379

    Back to the top


    Powered by Savane 3.1-cleanup1