(
Jump to the original submission)
Mon 26 Mar 2012 11:21:22 AM UTC, comment #8:
No.
|
Mon 26 Mar 2012 10:52:47 AM UTC, comment #7:
Do you reconsider further clean-up in another step?
|
Mon 26 Mar 2012 12:16:45 AM UTC, comment #6:
Comment #3 correclty mentions a typographical error only; that is what was addressed.
|
Sun 25 Mar 2012 02:04:20 PM UTC, comment #5:
Thanks for your update.
I wonder that you did not dare to delete such duplicate symbols with your last commit.
|
Sun 25 Mar 2012 08:00:55 AM UTC, comment #4:
Yes CDIO_CD_CD_FRAMSIZE_RAW is a typographical error. It has been corrected in git. Thanks.
|
Sat 24 Mar 2012 05:05:49 PM UTC, comment #3:
I assume that the symbol "CDIO_CD_CD_FRAMESIZE_RAW" contains a typo.
Would you like to integrate the appended adjustment into your source code repository?
(file #25460)
|
Sun 18 Mar 2012 05:50:47 PM UTC, comment #2:
I would prefer a clean-up for duplicate symbols.
|
Sun 18 Mar 2012 05:46:41 PM UTC, comment #1:
The #defines are what the code uses after the C-Preprocessor is used. The enums are used inside a debugger such as gdb.
Whether or not it is safe to remove them, I see no reason to do so.
|
Mon 12 Mar 2012 07:10:34 PM UTC, original submission:
I wonder why a couple of preprocessor definitions (like "CDIO_CD_..." and "M2...") are kept in the header file "sector.h" while the same values are provided by enumerations. Is it safer to delete them?
Would you like to get rid of the symbol "CDIO_CD_CD_FRAMESIZE_RAW"?
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 5 latest changes.