bugGNU TeXmacs - Bugs: bug #35783, Non ported or not completely...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35783: Non ported or not completely correctly ported widgets from X11

Submitted by:  Joris van der Hoeven <vdhoeven>
Submitted on:  Sat 10 Mar 2012 04:12:25 PM UTC  
 
Category: Qt portPriority: 7 - High
Item Group: ErrorStatus: In Progress
Privacy: PublicAssigned to: Miguel de Benito <mdbenito>
Originator Name: Joris van der HoevenOpen/Closed: Closed
Release: 1.0.7.14Release: None
Fixed Release: NoneFixed Release: 
Keywords: 

(Jump to the original submission Jump to the original submission)

Sat 21 Apr 2012 03:37:28 PM UTC, comment #16:

Remaining bugs moved to:

https://savannah.gnu.org/bugs/index.php?36263

https://savannah.gnu.org/bugs/index.php?36264

https://savannah.gnu.org/bugs/index.php?36265

Joris van der Hoeven <vdhoeven>
Project Administrator
Sat 21 Apr 2012 03:04:54 PM UTC, comment #15:

I am now going to submit separate bug items for the remaining issues.

Joris van der Hoeven <vdhoeven>
Project Administrator
Fri 23 Mar 2012 09:07:13 PM UTC, comment #14:

The problem with the refresh widget is now here:

https://savannah.gnu.org/bugs/index.php?35970

Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Wed 21 Mar 2012 02:18:40 PM UTC, comment #13:

Thanks for the testing. This is probably a bug in my part of the code, since the behaviour is incorrect in X11 as well. Please fill out a separate bug report.

Joris van der Hoeven <vdhoeven>
Project Administrator
Wed 21 Mar 2012 11:19:51 AM UTC, comment #12:

I've added a refresh_widget. However I cannot thoroughly test because I don't really understand the syntax. Can you please provide some information?

The following works:

But the following doesn't:

However, enclosing it in a for loop does:

But not evaluating widget82-list causes it not to work again:

See the attached .tm file

(file #25427)

Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Mon 12 Mar 2012 09:55:36 PM UTC, comment #11:
  • Sorry for the confusion. Yes, I meant the tabs_widget. I see that you already improved it a lot, although some further tweaking is necessary.
  • About the extra space: do (open-preferences) and go to the Keyboard section. Although 'pagedown' should fit in the cell, the width of this cell has unnecessarily been increased. Why?
  • Aligned widget: in the preferences widget, go to the sections Converters and Html. If I resize the window, why does the aligned table move to the right? It should not.
Joris van der Hoeven <vdhoeven>
Project Administrator
Mon 12 Mar 2012 09:33:10 PM UTC, comment #10:
  • Choice widget (...)
    • You mean tabs_widget, right? And yes, it's standard (I didn't claim the contrary, I was referring to choices_widget (multiple choice from a list))
  • The size of the choice widget (...)
    • Again, this is the tabs_widget? If yes, then I'm aware of the problem and I committed a few improvements. However, switching tabs in some particular order loses track of resizing. I'm investigating.
  • "it seems that an extra space of about 3em is automatically added by Qt, so it might be necessary to automatically increase the width by a similar amount."
    • I don't follow you, sorry. I don't see this extra space.
  • Stretching of columns in align_widget
    • Should have improved now.
  • Centered & aligned:
    • Seem to work now.

= Not yet implemented =

  • Resize widgets
  • Texmacs output widgets
  • Refresh widgets
Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Mon 12 Mar 2012 12:02:11 PM UTC, comment #9:
  • Choice widget: the System Preferences widget of Mac OS does resize the window when necessary. So resizing is definitely the standard behaviour for preferences widgets.
  • The size of choice widget is completely wrong now. Some text gets squeezed to a few pixels height now.
  • I see for the width of enums. However, it seems that an extra space of about 3em is automatically added by Qt, so it might be necessary to automatically increase the width by a similar amount.
Joris van der Hoeven <vdhoeven>
Project Administrator
Mon 12 Mar 2012 01:36:53 AM UTC, comment #8:

=== Fixed ===

  • Choice widget:
    • Yes this is standard behaviour under MacOS, Windows, KDE and probably Gnome.
  • 4px horizontal spacing between the columns and 2px vertical spacing between rows:
    • Indeed. Fixed. (6px & 2px)
  • The width parameter for enums is not respected.
    • It is, but not if it's smaller than the minimum size of the biggest item. In the keyboard preferences widget definition, try changing "5em" to "10em". What I don't understand is why in the X11 version you see all of the text in those enums, when 5em=5*standard point size < width of the items. They should be cropped, right?
  • The bold text indication is not respected.
    • Fixed. Now bold, mini and the other styles as well as colors are applied to text_widgets, input boxes, toggles, etc.

=== In progress ===

  • Why is the entire alignment table itself being right aligned?
    • It is not: both columns are stretching equally. One has to manually tell QT which columns take priority over others or it will assign every one the same weight. I'm looking for a workaround.
  • The size of the window is not automatically set to the size of the actual widget when changing tabs.
    • Done, but still requires tweaking: because of the order the layouts are assigned, the window is not following the resizing tabs, so strange things happen. The test widgets look ugly right now, yes.
  • texmacs-input-widget is still a bit buggy
    • This probably requires rethinking of the (double'd) double buffering. Later.
  • centered & aligned require some work yet.
Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Sun 11 Mar 2012 05:22:16 PM UTC, comment #7:

It could be that the problem with 'centered' is really a problem with 'aligned'. In some cases, (e.g. the Converters section in the preferences widget), it seems that the widths of both columns are the same by default. By the default, the width of each column should of course be the maximum of the default widths of the cells in the column.

Joris van der Hoeven <vdhoeven>
Project Administrator
Sun 11 Mar 2012 05:15:38 PM UTC, comment #6:
  • The glue widget does not seem to be completely OK. For instance, 'centered' does not work as it should.
    • Could you please provide an example? I've rewritten the (colorless) glue widget using QSpacers and everything looks the same, so the current qt_glue_widget does what QT does.
Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Sun 11 Mar 2012 04:51:18 PM UTC, comment #5:

Hmm, by doing (open-preferences), I see a lot of other problems:

  • The width parameter for enums is not respected. When specifying 1w, then you might want to do what you do now.
  • The size of the window is not automatically set to the size of the actual widget when changing tabs.
  • The bold text indication is not respected.
  • For the Converters section, the hspace between columns of alignments is definitely to small. Why is the entire alignment table itself being right aligned?
Joris van der Hoeven <vdhoeven>
Project Administrator
Sun 11 Mar 2012 04:42:36 PM UTC, comment #4:

Thanks for the fixes Miguel. Some remarks:

  • For the Qt version, we might want to add 4px horizontal spacing between the columns and 2px vertical spacing between rows. What do you think?
  • I now understand how the Choices widget works. However, I do not find this really intuitive. Is this really the standard behaviour under MacOS? I would expect to be able to toggle items by clicking twice with the mouse.
  • As to the TeXmacs input widget, when it is opened or resized, then a lot of flickering is going on.
Joris van der Hoeven <vdhoeven>
Project Administrator
Sun 11 Mar 2012 04:23:56 PM UTC, comment #3:

*Align widgets should be aligned rl and not ll or lr.
**Fixed. But with a side effect (...)

The side effect wasn't really that but anyway, it's fixed now. a qt_decode_length() decodes tm lengths into QSizes.

Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Sun 11 Mar 2012 02:12:36 PM UTC, comment #2:
  • Align widgets should be aligned rl and not ll or lr.
    • Fixed. But with a side effect: items being aligned inherit the alignment: QComboBoxes in particular are shrunk. I'm investigating.
Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Sun 11 Mar 2012 01:44:05 PM UTC, comment #1:
  • Choice returns (incorrectly) a list of one answer instead
    • Fixed.
  • Choices only allows to select one possibility.
    • In my system it does. Click and drag or use CMD+click, or SHIFT+click.
  • texmacs-input-widget is still a bit buggy,
    • Input works and the context menu does as well. Can you please be more specific?
Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Sat 10 Mar 2012 04:12:25 PM UTC, original submission:

The following problems are still present concerning
the Qt ports of the recently added X11 widgets.
Please look at the file men-test.scm for a small test suite.

Incorrect behaviour
-------------------

  • Align widgets should be aligned rl and not ll or lr.
  • The glue widget does not seem to be completely OK.

For instance, 'centered' does not work as it should.

  • Choice returns (incorrectly) a list of one answer instead

of the answer itself

  • Choices only allows to select one possibility,

whereas multiple choices should be possible.

  • texmacs-input-widget is still a bit buggy,

although fundamentally OK.

  • The footer buttons for most of the test widgets are

displayed at incorrect positions.

Not yet implemented
-------------------

  • Resize widgets
  • Texmacs output widgets
  • Refresh widgets
Joris van der Hoeven <vdhoeven>
Project Administrator

 

Attached Files
file #25427:  refresh_widget.tm added by mdbenito (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mdbenito (Posted a comment)
  • -unavailable- added by vdhoeven (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 21 Apr 2012 03:37:28 PM UTCvdhoevenOpen/ClosedAccepted=>Closed
    Thu 22 Mar 2012 01:13:38 PM UTCmdbenitoStatusConfirmed=>In Progress
      Open/ClosedOpen=>Accepted
    Wed 21 Mar 2012 11:19:51 AM UTCmdbenitoAttached File-=>Added refresh_widget.tm, #25427
    Sun 11 Mar 2012 01:44:20 PM UTCmdbenitoAssigned tomgubi=>mdbenito
    Sat 10 Mar 2012 04:13:22 PM UTCvdhoevenPriority5 - Normal=>7 - High
      Item GroupNone=>Error

    Back to the top


    Powered by Savane 3.1-cleanup1