bugGNU recutils - Bugs: bug #35742, Unsafe include guards

 
 

bug #35742: Unsafe include guards

Submitted by:  Markus Elfring <elfring>
Submitted on:  Wed 07 Mar 2012 02:50:31 PM UTC  
 
Category: librecSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Jose E. Marchesi <jemarch>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 13 Mar 2012 09:17:25 PM UTC, comment #2:

I would prefer longer identifiers. Would you like to make all include guards really unique?

Markus Elfring <elfring>
Tue 13 Mar 2012 08:44:31 PM UTC, comment #1:

Hi.

I changed the REC_H guard to read GNU_REC_H. Regarding rec-utils.h, that header file is not installed, so there is no reason to change the general rule used to name the guards.

Thanks for the report.

Jose E. Marchesi <jemarch>
Project AdministratorIn charge of this item.
Wed 07 Mar 2012 02:50:31 PM UTC, original submission:

I find your include guards "REC_H" and REC_UTILS_H too short.
How do you think about to add an UUID to them so that the reuse of the header files will become safer?

Markus Elfring <elfring>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jemarch (Posted a comment)
  • -unavailable- added by elfring (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 13 Mar 2012 08:44:31 PM UTCjemarchStatusNone=>Fixed
      Assigned toNone=>jemarch
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1