bugGNU Octave - Bugs: bug #35708, patch for cygwin build

 
 

bug #35708: patch for cygwin build

Submitted by:  marco atzeri <matzeri>
Submitted on:  Sat 03 Mar 2012 02:57:10 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: Jacob Dawid <jacobdawid>
Originator Name: Open/Closed: Closed
Release: devOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 07 Aug 2012 07:17:39 AM UTC, comment #2:

we can close the bug as solved

marco atzeri <matzeri>
Sun 27 May 2012 09:45:39 PM UTC, comment #1:

I have applied the changes with qterminal along with the changeset http://hg.savannah.gnu.org/hgweb/octave/rev/c952f1e35e50 .

See here:
http://code.google.com/p/qterminal/source/detail?r=5c51db4e3b1fcce6a05c59af5be78f43ebc24db4

Please test if you build now without problems.

Jacob Dawid <jacobdawid>
Project MemberIn charge of this item.
Sat 03 Mar 2012 02:57:10 PM UTC, original submission:

attached patch to allow build on cygwin and additionally
solve the build failure on a separate tree.
It is versus changeset: 13693:d738c29a2528

qterminal/libqterminal/libqterminal.pro
qterminal/qterminal/qterminal.pro

both require
DEFINES += HAVE_PTY_H HAVE_OPENPTY
for correctly defining the PTY

and the removal of
DESTDIR = .
to allow the build on a separate tree.
With DESTDIR defined, the Makefile will have a
rm -r ./libqterminal.a
that destroy the just built library. With no
definition the build works fine.

qterminal/libqterminal/unix/kpty.cpp
needs some missing
#ifndef HAVE_OPENPTY

see
http://kde4libs.sourcearchive.com/documentation/4.4.1/kpty_8cpp-source.html

marco atzeri <matzeri>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25255:  gui_2.patch added by matzeri (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Updated the item)
  • -unavailable- added by matzeri (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 07 Aug 2012 12:39:08 PM UTCjordighStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 27 May 2012 09:45:39 PM UTCjacobdawidStatusNone=>Ready For Test
    Mon 05 Mar 2012 03:43:25 PM UTCjacobdawidAssigned toNone=>jacobdawid
    Sat 03 Mar 2012 02:57:10 PM UTCmatzeriAttached File-=>Added gui_2.patch, #25255

    Back to the top


    Powered by Savane 3.1-cleanup1