Mon 05 Mar 2012 02:42:44 PM UTC, comment #5:
Thanks, I pushed a modified version of your patch:
http://hg.savannah.gnu.org/hgweb/octave/rev/ec660526ae50
Since this was a regression, I patched on the stable branch.
Note the following modifications over your patch:
1) The commit message is different. Short one-line description, longer description saying the file and function in which the change is.
2) Added a test to verify the correctness of this change.
3) No tabs! For some reason, your second diff still had tabs.
4) Spaces before opening parentheses in function calls, but not in front of indexing. You were missing a couple of spaces.
5) And it's done with hg. ;-)
If you submit future patches, please try to follow these suggestions.
Thanks again, closing this report.
|