bugGNU Octave - Bugs: bug #35418, strread.m bugs (missing...

 
 

bug #35418: strread.m bugs (missing ";" / undue parse errors / code cleanup)

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Tue 31 Jan 2012 09:55:29 PM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: 3.6.0Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 02 Feb 2012 06:47:43 PM UTC, comment #1:

I applied your patch to the stable branch which will become 3.6.1 very shortly.

Rik <rik5>
Project Administrator
Tue 31 Jan 2012 09:55:29 PM UTC, original submission:

1. In some corner cases, strread.m echoed intermediate data due to a missing ";" at L.673.

2. I fixed a few instances where strread didn't adequately check array bounds in Ls. 442-506. This led to undue messages about "unable to parse file with given format string").

3. Those instances + a few more (7 in total) contained identical code => I moved this code elsewhere and replaced it by a boolean flag in the 7 instances.
Indentation in this area fixed as well.

All tests pass (also for textscan & textread)

Patch attached.
(Sorry no changeset, my Windows XP build system got fubarred lately, had to re-install and I'm still installing loads of SW.)

Suggested text for changeset:

  • fixed missing ";"
  • fixed array bound checking in lines 442-506
  • code cleanup
Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24945:  strread-3.6.0.diff added by philipnienhuis (4KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 02 Feb 2012 06:47:43 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Tue 31 Jan 2012 09:55:29 PM UTCphilipnienhuisAttached File-=>Added strread-3.6.0.diff, #24945

    Back to the top


    Powered by Savane 3.1-cleanup1