bugGNUstep - Bugs: bug #35380, NSImageView appears faded on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #35380: NSImageView appears faded on Windows XP

Submitted by:  Jonathan Gillaspie <jonathanosx>
Submitted on:  Thu 26 Jan 2012 06:40:45 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Tue 31 Jan 2012 02:31:54 PM UTC, comment #6:

Thanks Eric, That's fixed it for me (I'm marking it closed and fixed)

Jonathan Gillaspie <jonathanosx>
Project Member
Tue 31 Jan 2012 02:30:36 AM UTC, comment #5:

Thanks for the sample. It turns out the dimming only happens on Cocoa when the border is set to NSImageFrameNone! I just committed a patch to follow that behaviour.

Eric Wasylishen <ericw>
Project Member
Tue 31 Jan 2012 01:26:31 AM UTC, comment #4:

Ok, so I had to dig a little deeper. It turns out that somewhere further than I imagined in our code we actually intentionally disable the NSImageView when we first load it. The comment being "Disabling Image View prevents it from being tabbed to"; I guess that was important when we first put this in.

Interestingly however on Mac OS X, that does NOT cause a greying out of the Image itself (just of the border rectangle). I've attached a 2.X NIB to run on Mac OS X (10.6.8 for me). If you just run it in interface test mode it uses bindings to let you enable and disable the NSImageView, you can let me know what you see.

I don't especially care, but it seems that Cocoa doesn't grey the image. Unless I'm missing something (and I often am).

So, I've reopened the bug pending your decision of how you want it to behave.

(file #24933)

Jonathan Gillaspie <jonathanosx>
Project Member
Sat 28 Jan 2012 10:31:13 AM UTC, comment #3:

I could not find any bug report that talks about the enabled flag not working properly for NSImageView decoding. Looking at the code I see that we decode NSEnabled in NSControl, the super class of NSImageView, and the code there looks correct to me.

Could you please provide two NIB files, one where the image view is enabled and one where it is disabled and tell me which one isn't working correctly? There might still be a problem here as we decode the enabled state twice, once for the cell and also for the control. No idea what happens when these two differ.

It is different for Gorm files, the encoding/decoding of the enabled flag in NSControl has only been implemented for keyed coding, so a Gorm file relies on the cell for the encoding of the enabled state.

Fred Kiefer <FredKiefer>
Project Member
Fri 27 Jan 2012 10:20:26 PM UTC, comment #2:

So I've confirmed that this is the situation here and the greying behaving when disabled is perfectly correct. What this exposes is that the NSImageViews being loaded from the .nib aren't properly setting their Enabled flag. (We've never disabled or had any user action to disable them). At a minimum I'll close this bug, I think the Enabled: flag problem for nibs is already filed.

Jonathan Gillaspie <jonathanosx>
Project Member
Thu 26 Jan 2012 07:18:20 PM UTC, comment #1:

I think this a change I made recently so that NSImabeView draws its image at 50% if it is disabled (-isEnabled NO). The idea is to make it easy to gray out image views. I did a quick check on Cocoa when I implemented this and it does the same thing.

Assuming there aren't other bugs in gui, your image view should return NO for isEnabled, and if so, try calling setEnabled: YES on it which should fi the problem (or set the image view to be enabled in gorm/interface builder.)

Eric Wasylishen <ericw>
Project Member
Thu 26 Jan 2012 06:40:45 PM UTC, original submission:

Our application displays NSImages in an NSImageView, a change has made those images come up faded/washed out. I"m not sure if this is happening in the backend compositing (seems more likely) or if it's a more general GUI issue.

We know that the image itself is properly read into memory because we use the bitmap within the application, it's JUST in the display in NSImageView that the problem occurs.

This is observed on a build (2012-01-25) of GS common libraries with Windows XP, using the WINUXTheme.

It works fine on the prior release of GNUstep in this environment. (The April '10 release).

Screen shot attached...

Jonathan Gillaspie <jonathanosx>
Project Member

 

Attached Files
file #24933:  EnableNSImageTest.nib.zip added by jonathanosx (6KiB - application/octet-stream - NIb that enables and disables (using bindings).)
file #24898:  Screen shot 2012-01-26 at 11.35.27 AM.png added by jonathanosx (45KiB - image/png - Image show in NSImageView and Window's Image Viewer App)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by ericw (Posted a comment)
  • -unavailable- added by jonathanosx (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 31 Jan 2012 02:31:54 PM UTCjonathanosxStatusNeed Info=>Fixed
      Open/ClosedIn Test=>Closed
    Tue 31 Jan 2012 01:26:31 AM UTCjonathanosxAttached File-=>Added EnableNSImageTest.nib.zip, #24933
      StatusDuplicate=>Need Info
      Open/ClosedClosed=>In Test
    Sat 28 Jan 2012 10:31:13 AM UTCFredKieferCategoryBackend=>Gui/AppKit
    Fri 27 Jan 2012 10:20:26 PM UTCjonathanosxStatusNone=>Duplicate
      Open/ClosedOpen=>Closed
    Thu 26 Jan 2012 06:40:45 PM UTCjonathanosxAttached File-=>Added Screen shot 2012-01-26 at 11.35.27 AM.png, #24898

    Back to the top


    Powered by Savane 3.1-cleanup1