bugGNU Octave - Bugs: bug #35378, undefined variable in ols.m

 
 

bug #35378: undefined variable in ols.m

Submitted by:  None
Submitted on:  Thu 26 Jan 2012 12:48:15 PM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Michael CreelOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 3.6.0
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 09 Feb 2012 06:37:42 PM UTC, comment #4:

This was fixed by Jordi in this changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/71efccec5936). It will be in the new 3.6.1 bug fix release expected within the next week. Alternatively, the user can build from the development sources to get the fix.

Rik <rik5>
Project Administrator
Thu 02 Feb 2012 09:44:22 PM UTC, comment #3:

I have a fix. I'll commit it soon.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Thu 02 Feb 2012 06:56:37 PM UTC, comment #2:

Jordi, should the Cholesky patch be reverted for the stable branch? It seems more important to have the function working as documented on stable and to experiment with performance improvements on the default branch. JWE is talking about issuing a 3.6.1 release very soon so we could actually get this change in to the stable release.

Rik <rik5>
Project Administrator
Thu 26 Jan 2012 01:31:57 PM UTC, comment #1:

This patch isn't correct. The x matrix needn't be of full rank (nor does it have more rows than columns).

I don't think we can do better than calling rank, which does an SVD. I was trying to avoid that using a much cheaper Cholesky factorisation.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Thu 26 Jan 2012 12:48:15 PM UTC, original submission:

statistics/base/ols.m fails if called with two arguments because 'rnk' is not defined. A suggested fix is attached.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24897:  ols.m added by None (4KiB - text/x-matlab - suggested fix for ols.m)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 09 Feb 2012 06:37:42 PM UTCrik5StatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Thu 02 Feb 2012 06:56:37 PM UTCrik5StatusNone=>Confirmed
    Thu 26 Jan 2012 12:48:15 PM UTCNoneAttached File-=>Added ols.m, #24897

    Back to the top


    Powered by Savane 3.1-cleanup1