bugGNU Octave - Bugs: bug #35089, isdefinite: patch to use tolerance...

 
 

bug #35089: isdefinite: patch to use tolerance for ishermitian test

Submitted by:  Lukas Reichlin <paramaniac>
Submitted on:  Fri 16 Dec 2011 04:17:36 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 4Item Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 3.4.3Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 19 Dec 2011 04:48:15 AM UTC, comment #1:

I applied your patch in this changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/b2e9c4b0c4f8). It will make it in to the 3.6.0 release.

Rik <rik5>
Project Administrator
Fri 16 Dec 2011 04:17:36 PM UTC, original submission:

Dear Octave Community

I created a patch (see attachment) for isdefinite.m from core octave. The intention of the patch is to use the tolerance given in isdefinite for the built-in ishermitian test. Currently, no tolerance is given such that it tests for exact zero. This caused problems. In the attached file anderson.m (requires package control-2.2.3) is an example where

fails the ishermitian test (calling sequence lqr.m > care.m > isdefinite.m > ishermitian.m) while

passes the same test. The only difference are the brackets and thus the order of the two multiplications. In the first case, some numerical errors are introduced that make the ishermitian test inside isdefinite fail. My patch solves this problem.

It would be nice if the patch could be included in octave 3.6.0

Best regards,
Lukas

Lukas Reichlin <paramaniac>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24609:  isdefinite_patch.txt added by paramaniac (708B - text/plain - diff -cp)
file #24610:  anderson.m added by paramaniac (1KiB - application/octet-stream - diff -cp)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by paramaniac (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 19 Dec 2011 04:48:15 AM UTCrik5Priority5 - Normal=>4
      StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Fri 16 Dec 2011 04:17:36 PM UTCparamaniacAttached File-=>Added isdefinite_patch.txt, #24609
      Attached File-=>Added anderson.m, #24610

    Back to the top


    Powered by Savane 3.1-cleanup1