bugGNU Octave - Bugs: bug #34907, legend displaynames on fltk

 
 

bug #34907: legend displaynames on fltk

Submitted by:  Ben Abbott <bpabbott>
Submitted on:  Sat 26 Nov 2011 06:19:02 PM UTC  
 
Category: Plotting with OpenGLSeverity: 5 - Blocker
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 16 Jul 2012 07:07:04 PM UTC, comment #10:

The fix got applied for 3.8.0. If you're in a hurry, you can either build from Mercurial or attempt to backport the fix to the stable release.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Mon 16 Jul 2012 05:37:16 PM UTC, comment #9:

first thanks for the bug fixing !

any idea when this will be available in the "standard" source ?
I am using 3.6.2 on Ubuntu (the current "up-to-date" available download) and this problem is showing up.

Was the problem fixed in 3.6.x ?

Thx !

Fab.

foehler <foehler>
Thu 15 Mar 2012 10:52:01 PM UTC, comment #8:

I pushed the change

http://hg.savannah.gnu.org/hgweb/octave/rev/d16638f73691

Ben Abbott <bpabbott>
Project Member
Thu 15 Mar 2012 08:18:10 PM UTC, comment #7:

Kostas,

I've attached a changeset. I'll test it later and push it if all goes well and there are no objections,

(file #25372)

Ben Abbott <bpabbott>
Project Member
Thu 15 Mar 2012 07:10:54 PM UTC, comment #6:

Ben, sorry no time for writing a changelog could you please do the commit yourself? Just replace the line:

glRasterPos3d (pos(0), pos(1), pos(2));

with

glRasterPos3d (pos(0), pos(1), pos.numel () > 2 ? pos(2) : 0.0);

in the original patch with respect to gl-renderer.cc jwe has also changed the constness of pos but I don't know why. Maybe you could ask him.

Konstantinos Poulios <logari81>
Project Member
Mon 12 Mar 2012 12:58:44 PM UTC, comment #5:

Kostas,

Will you have time to fix this ?

Ben Abbott <bpabbott>
Project Member
Mon 12 Mar 2012 09:11:58 AM UTC, comment #4:

I am reopenning this one because the same fix needs to be applied to gl2ps-renderer.cc, otherwise legend names are not displayed on printed plots.

Konstantinos Poulios <logari81>
Project Member
Wed 30 Nov 2011 01:55:38 PM UTC, comment #3:

the fix works for me as well.

thanks

Konstantinos Poulios <logari81>
Project Member
Wed 30 Nov 2011 03:05:00 AM UTC, comment #2:

Yes, your changeset fixed the problem for me.

I've set the status to "fixed" and closed the bug report.

Ben Abbott <bpabbott>
Project Member
Wed 30 Nov 2011 12:03:49 AM UTC, comment #1:

I checked in the following changeset.

http://hg.savannah.gnu.org/hgweb/octave/rev/0fea4cf22f88

Let me know whether this change also fixes the problem for you. If so the, I'll close the report.

John W. Eaton <jwe>
Project Administrator
Sat 26 Nov 2011 06:19:02 PM UTC, original submission:

I have just found a regression in the fltk backend. Legend text will not show up with the current default branch:

if this is confirmed and no one else is available for fixing it, I will do it before the 3.6 release.

Kostas

Ben Abbott <bpabbott>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25372:  changeset.patch added by bpabbott (733B - application/octet-stream - first changeset)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by foehler (Posted a comment)
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by logari81 (Posted a comment)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by bpabbott (Submitted the item)
  • -unavailable- added by bpabbott (Kostas, I thought it best to add a bug report so that this doesn't get forgotten.)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 06 Apr 2012 02:58:55 PM UTCrik5StatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Thu 15 Mar 2012 08:18:10 PM UTCbpabbottAttached File-=>Added changeset.patch, #25372
    Mon 12 Mar 2012 09:11:58 AM UTClogari81StatusFixed=>In Progress
      Open/ClosedClosed=>Open
    Wed 30 Nov 2011 03:05:00 AM UTCbpabbottStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 26 Nov 2011 07:55:40 PM UTCbpabbottSummarylegend displaynames =>legend displaynames on fltk
    Sat 26 Nov 2011 06:19:02 PM UTCbpabbottCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1