bugGNUstep - Bugs: bug #34835, Harmfull sed search/replace calls...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34835: Harmfull sed search/replace calls in pathtls.m4 and pathxml.m4

Submitted by:  Felix Geyer <debfx>
Submitted on:  Tue 15 Nov 2011 05:29:41 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Thu 19 Jan 2012 09:38:17 AM UTC, comment #1:

Agreed ... thanks for pointing this out.
I modified those files as suggested.

Richard Frith-Macdonald <CaS>
Project Member
Tue 15 Nov 2011 05:29:41 PM UTC, original submission:

config/pathtls.m4 and config/pathxml.m4 in gnustep-base contain harmful sed search/replace calls:
XML_LIBS=`echo $XML_LIBS | sed -e 's|-L/usr/lib||'`

This completely breaks if libxml is in a subpath of /usr/lib (e.g. /usr/lib/x86_64-linux-gnu):

configure:9998: x86_64-linux-gnu-gcc -o conftest -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -I/usr/include/libxml2 -D_FORTIFY_SOURCE=2 -I/usr/include/GNUstep -I/usr/local/include/GNUstep -I/usr/local/include/GNUstep -Wl,-z,defs -Wl,--as-needed -L/usr/lib -L/usr/local/lib -L/usr/local/lib conftest.c /x86_64-linux-gnu -lxml2 -lffi -lrt -ldl -lpthread -lz >&5
x86_64-linux-gnu-gcc: error: /x86_64-linux-gnu: No such file or directory

There is absolutely no harm in passing -L/usr/lib to the linker so please remove that sed call.

Felix Geyer <debfx>

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by debfx (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 Jan 2012 09:38:17 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 15 Nov 2011 05:29:41 PM UTCdebfxAttached File-=>Added configure_drop_harmful_sed_call.patch, #24382

    Back to the top


    Powered by Savane 3.1-cleanup1