bugGnash - The GNU Flash player - Bugs: bug #34699, Segfault on Edit->Preferences...

 
 

bug #34699: Segfault on Edit->Preferences selection from GTK gui menu

Submitted by:  Sandro Santilli <strk>
Submitted on:  Sun 30 Oct 2011 02:08:48 PM UTC  
 
Category: gui-gtkSeverity: 6 - Security
Release: masterStatus: Fixed
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 30 Oct 2011 08:50:49 PM UTC, comment #12:

Fixed by http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=de126bf

Sandro Santilli <strk>
Project Member
Sun 30 Oct 2011 07:25:50 PM UTC, comment #11:

Is it safe to use __null rather than NULL from user space ?
Isn't there an header for inclusion to redefine NULL or similar ?

Sandro Santilli <strk>
Project Member
Sun 30 Oct 2011 06:20:22 PM UTC, comment #10:

Should be fixed as of #f6f7f6f, at least it now works for me.

Rob Savoye <rsavoye>
Project Administrator
Sun 30 Oct 2011 04:52:51 PM UTC, comment #9:

See also http://stackoverflow.com/questions/1674150/null-definition-problem-on-64-bit-system .

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 30 Oct 2011 04:51:42 PM UTC, comment #8:

I can't reproduce it on my debian testing amd64.

Gabriele Giacone <gg0>
Project Member
Sun 30 Oct 2011 04:43:13 PM UTC, comment #7:

Yes. I believe it is because NULL is being defined as zero (integer). On 64-bit machines, because integers are 32-bit and pointers 64, this causes NULL arguments to vararg function to be treated as zero integers (and thus, the compiler does not know when the last argument has been passed).

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 30 Oct 2011 04:37:51 PM UTC, comment #6:

On a 64bit Ubuntu 11.11 machine, I get the segfault with Edit->Preferences. On a 32 bit 11.11 machine, it doesn't segfault, so it does look like a 64bit issue.

Rob Savoye <rsavoye>
Project Administrator
Sun 30 Oct 2011 04:23:31 PM UTC, comment #5:

I suspect this is only reproducible on 64-bit machines.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 30 Oct 2011 04:12:31 PM UTC, comment #4:

On my Fedora 13 and Ubuntu 11.11 (oneiric), I get no warnings compiling gui, nor does Edit->Preferences segfault.

Rob Savoye <rsavoye>
Project Administrator
Sun 30 Oct 2011 03:37:29 PM UTC, comment #3:

It is reproducible on Ubuntu 10.04 and Fedora 16. Can you reproduce the warnings in gui/?

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 30 Oct 2011 03:27:30 PM UTC, comment #2:

What distro are you using ? This doesn't segfault with master on my Fedora machine, I'll try Debian & Ubuntu next.

Rob Savoye <rsavoye>
Project Administrator
Sun 30 Oct 2011 03:20:31 PM UTC, comment #1:

If you define NULL as __null in gtk.cpp, the segfault does not occur. It seems this coincides with warnings about missing function sentinels in gtk.cpp. These warnings were introduced by the following commit, according to git bisect:

commit 60dc390604b29f511e115a7a0e8a7aa25efa2e46
Merge: 1b2b90e 4f5c52f
Author: Rob Savoye <rob@welcomehome.org>
Date: Sun Apr 17 18:18:40 2011 -0600

big merge from master

I am not sure how to trace this issue further.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun 30 Oct 2011 02:08:48 PM UTC, original submission:

As simple as it is, with 65c8cb051 (current master) you get a segfault when selecting Edit->Preferences from GTK gui menu.

An empty SWF file is enough to reproduce. Any movie reproduces here.

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gg0 (Posted a comment)
  • -unavailable- added by rsavoye (Updated the item)
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 30 Oct 2011 08:50:49 PM UTCstrkStatusReady For Test=>Fixed
      Assigned torsavoye=>bjacques
      Open/ClosedOpen=>Closed
    Sun 30 Oct 2011 06:20:22 PM UTCrsavoyeStatusConfirmed=>Ready For Test
    Sun 30 Oct 2011 03:37:29 PM UTCbjacquesStatusNeed Info=>Confirmed
    Sun 30 Oct 2011 03:27:30 PM UTCrsavoyeStatusConfirmed=>Need Info
    Sun 30 Oct 2011 03:20:31 PM UTCbjacquesStatusNone=>Confirmed
      Assigned toNone=>rsavoye

    Back to the top


    Powered by Savane 3.1-cleanup1