bugGNUstep - Bugs: bug #34552, back configure doesn't check for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #34552: back configure doesn't check for <X11/Extensions/shape.h>

Submitted by:  julian <julian_>
Submitted on:  Sat 15 Oct 2011 12:03:04 AM UTC  
 
Category: BackendSeverity: 3 - Normal
Item Group: InstallationStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Thu 20 Oct 2011 10:31:56 AM UTC, comment #6:

no problem. i can confirm that it works now ;-)

julian <julian_>
Thu 20 Oct 2011 08:44:35 AM UTC, comment #5:

Thank you for being so patient. I gave it another try and hopefully got more of the shm usage covered this time.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Wed 19 Oct 2011 01:00:29 PM UTC, comment #4:

no problem.

still doesn't work:

Compiling file XWindowBuffer.m ...
XWindowBuffer.m:255:15: warning: implicit declaration of function 'XShmDetach'
is invalid in C99 [-Wimplicit-function-declaration]
XShmDetach(wi->display, &wi->shminfo);
^
XWindowBuffer.m:257:33: error: member reference base type 'int' is not a
structure or union
shmdt(wi->shminfo.shmaddr);
~~~~~~~~~~~ ^
XWindowBuffer.m:447:12: warning: implicit declaration of function 'XShmPutImage'
is invalid in C99 [-Wimplicit-function-declaration]
if (!XShmPutImage(display, drawable, gc, ximage,
^
XWindowBuffer.m:642:47: error: use of undeclared identifier 'ShmCompletion'
XShmGetEventBase(window->display) + ShmCompletion, &e))
^
XWindowBuffer.m:644:39: error: use of undeclared identifier
'XShmCompletionEvent'
[isa _gotShmCompletion: ((XShmCompletionEvent *)&e)->drawable];
^
XWindowBuffer.m:644:60: error: expected expression
[isa _gotShmCompletion: ((XShmCompletionEvent *)&e)->drawable];
^
XWindowBuffer.m:715:25: error: member reference base type 'int' is not a
structure or union
shmdt(shminfo.shmaddr);
~~~~~~~ ^
2 warnings and 5 errors generated.

julian <julian_>
Wed 19 Oct 2011 07:45:09 AM UTC, comment #3:

I added this missing guards for shm in the header as well. Could you please test once more.

Thank you for reporting and testing all this in detail.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Tue 18 Oct 2011 08:58:13 PM UTC, comment #2:

ok i wanted to verify the fix and un-installed the libxext-dev package again, but still no luck compiling back.

this time it doesn't trip on something shape.h related, but something XShm.h related:

In file included from XWindowBuffer.m:31:
../../Headers/x11/XWindowBuffer.h:28:10: fatal error: 'X11/extensions/XShm.h' file not found
#include <X11/extensions/XShm.h>

there is already an configure check for this so i guess there are just some guards missing. i am also not sure what will be missing from the backend if these headers aren't there?

julian <julian_>
Mon 17 Oct 2011 11:53:59 AM UTC, comment #1:

I added some tests to configure.ac and put conditional compilation around the two places where I know we are using the shape extension of X.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sat 15 Oct 2011 12:03:04 AM UTC, original submission:

back ./configure doesn't check for the presence of <X11/Extensions/shape.h>, but rather the compilation aborts when the header isn't present.

julian <julian_>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by julian_ (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 01 Nov 2011 07:14:01 PM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Mon 17 Oct 2011 11:53:59 AM UTCFredKieferStatusNone=>Ready For Test
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>In Test

    Back to the top


    Powered by Savane 3.1-cleanup1