bugGNU Octave - Bugs: bug #34389, demo ("loglog", 2) fails...

 
 

bug #34389: demo ("loglog", 2) fails for gnuplot toolkit

Submitted by:  Rik <rik5>
Submitted on:  Mon 26 Sep 2011 05:35:50 PM UTC  
 
Category: Plotting with OpenGLSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Ben Abbott <bpabbott>
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 01 Nov 2011 09:33:46 PM UTC, comment #7:

I pushed the proposed changeset.

http://hg.savannah.gnu.org/hgweb/octave/rev/bebd3ae908cb

and a second changeset to improve upon the semilog{x,y} demos.

http://hg.savannah.gnu.org/hgweb/octave/rev/d67c8bf52e20

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Tue 01 Nov 2011 04:04:46 PM UTC, comment #6:

Ben,
The changeset you posted works for me. I'd go ahead and commit it.

This is just an aside. To test your patch I ran the demos for loglog, semilogx, and semilogy. It seems like tests for semilogy were cut and pasted from semilogx and the actual labeling of the graphs is incorrect.

Rik <rik5>
Project Administrator
Tue 01 Nov 2011 12:22:38 PM UTC, comment #5:

I've attached a changeset. I've made a few silly mistakes trying to get this right. Can someone look this over for me to be sure I don't mess it up a 3rd time?

I"ve attached a changeset.

(file #24264)

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Tue 01 Nov 2011 11:50:11 AM UTC, comment #4:

I think FLTK is now behaving correctly. The 2nd demo for loglog is

For subplot (1,2,2) the ydir is "reverse". Thus, the values are min at the top (1e-5) and max at the bottom (1e1). For subplot (1,2,1) the min value is at the bottom (-1e1) and max at the top (-1e-5).

I've attached the result from ML R2011b.

(file #24263)

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Tue 01 Nov 2011 04:26:27 AM UTC, comment #3:

Is it really fixed for FLTK? In previous version of Octave using gnuplot the first subplot on the left has the line running from the lower left to the upper right.

At least now the FLTK toolkit produces two subplots, but they are identical with the line being drawn from the upper left to the lower right.

Rik <rik5>
Project Administrator
Mon 31 Oct 2011 11:55:37 PM UTC, comment #2:

This is now working for opengl, but that fix has resulted in a regression for gnuplot (the y-axis ticks for the example below are reversed)

I'm changing the title.

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Wed 28 Sep 2011 12:55:30 AM UTC, comment #1:

The failure is due to negative values on a log scale.

ML requires all data be positive or negative. The gnuplot backend has recently been modified to support the ML behavior.

In addition, the handle-graphics properties have also been modified, and are ML compatible.

I haven't studied what is needed for FLTK, but I expect all that is left is to modify gl-render.cc

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Mon 26 Sep 2011 05:35:50 PM UTC, original submission:

The plot should have two side-by-side plots which is the case with gnuplot. With FLTK, only the right-hand plot is shown.

This is with a recent development tip (changeset: 13228:e8c52b442a99)

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24264:  changeset.patch added by bpabbott (1KiB - application/octet-stream)
file #24263:  matlab.pdf added by bpabbott (4KiB - application/pdf - demo loglog 2 using ML R2011b)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bpabbott (Posted a comment)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 01 Nov 2011 09:33:46 PM UTCbpabbottStatusNone=>Fixed
      Assigned toNone=>bpabbott
      Open/ClosedOpen=>Closed
    Tue 01 Nov 2011 12:22:38 PM UTCbpabbottAttached File-=>Added changeset.patch, #24264
    Tue 01 Nov 2011 11:50:11 AM UTCbpabbottAttached File-=>Added matlab.pdf, #24263
    Mon 31 Oct 2011 11:55:37 PM UTCbpabbottSummarydemo ("loglog", 2) fails for FLTK toolkit=>demo ("loglog", 2) fails for gnuplot toolkit

    Back to the top


    Powered by Savane 3.1-cleanup1