bugGNU Wget - Bugs: bug #34188, wget has 0 exit code on transfer...

 
 

bug #34188: wget has 0 exit code on transfer failure

Submitted by:  None
Submitted on:  Thu 01 Sep 2011 02:34:39 PM UTC  
 
Category: TestingSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: Giuseppe Scrivano <gscrivano>
Originator Name: Originator Email: -unavailable-
Open/Closed: ClosedRelease: trunk
Operating System: GNU/LinuxReproducibility: Intermittent
Fixed Release: NonePlanned Release: 1.13.4
Regression: NoneWork Required: None
Patch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 13 Sep 2011 08:14:39 AM UTC, comment #1:

thanks for the report.

I am going to commit this patch which fixes the problem:

=== modified file 'src/ftp.c'
--- src/ftp.c 2011-03-11 14:25:58 +0000
+++ src/ftp.c 2011-09-13 08:05:12 +0000
@@ -2125,7 +2125,7 @@
if (start)
{
/* Just get everything. */
- ftp_retrieve_list (u, start, con);
+ res = ftp_retrieve_list (u, start, con);
}
else
{
@@ -2154,8 +2154,7 @@
if (opt.quota && total_downloaded_bytes > opt.quota)
return QUOTEXC;
else
- /* #### Should we return `res' here? */
- return RETROK;
+ return res;
}

/* The wrapper that calls an appropriate routine according to contents

Giuseppe Scrivano <gscrivano>
Project AdministratorIn charge of this item.
Thu 01 Sep 2011 02:34:39 PM UTC, original submission:

/tp64/tools/wget/1.13/bin/wget -N -d ftp://...

150 Opening BINARY mode data connection for testfile.zip (9811952387 Bytes).
done.
Length: 9811952387 (9.1G)

0% [ ] 6,684,672 533K/s in 11s

2011-09-01 09:21:14 (606 KB/s) - Data connection: Connection timed out; Closed fd 4
426 Data connection closed, file transfer testfile.zip aborted.
Data transfer aborted.
Giving up.

Closed fd 3

$echo $?
0

/tp64/tools/wget/1.13/bin/wget --version
GNU Wget 1.13 built on linux-gnu.

+digest -https +ipv6 -iri +large-file +nls -ntlm +opie -ssl

Wgetrc:
/tp64/tools/wget/1.13/etc/wgetrc (system)
Locale: /tp64/tools/wget/1.13/share/locale
Compile: gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC="/tp64/tools/wget/1.13/etc/wgetrc"
-DLOCALEDIR="/tp64/tools/wget/1.13/share/locale" -I. -I../lib
-I../lib -O2 -Wall
Link: gcc -O2 -Wall -lrt ftp-opie.o ../lib/libgnu.a

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gscrivano (Posted a comment)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 13 Sep 2011 08:14:39 AM UTCgscrivanoStatusNone=>Fixed
      Assigned toNone=>gscrivano
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>1.13.4

    Back to the top


    Powered by Savane 3.1-cleanup1