bugCompact Disc Input and Control Library - Bugs: bug #34125, cygwin compilation broken with...

 
 

bug #34125: cygwin compilation broken with sizeof changes (patch included)

Submitted by:  None
Submitted on:  Wed 24 Aug 2011 07:42:48 PM UTC  
 
Category: compilationSeverity: 5 - Average
Item Group: libcdioStatus: Works For Me
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Originator Email: -unavailable-Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 25 Aug 2011 01:49:47 PM UTC, comment #4:

I can't reproduce this problem.

Given this, the best thing to do is run with remake.

If it fails, it will give you a command invocation for just the failing part along with the directory it is in. Rerun using that from the given directory (e.g. man). If that fails, add the -x (trace) option and send that output.

The other thing remake can help with here is to set a breakpoint at the target that is failing (e.g. all-am) and then it can write the target out as a shell script which can then be debugged .with some small modification of the shell script.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Thu 25 Aug 2011 06:37:39 AM UTC, comment #3:

Yep, patch shows up here. I'll try to remember to use remake to debug later -- I thought about it, but had other work to do so didn't install the package, but when I have some time later I'll look into it again. Thanks!

Tianon <tianon>
Thu 25 Aug 2011 04:25:14 AM UTC, comment #2:

Thanks for fixing and reporting. The changes should now be reflected in the git repository. I have tested this, but please double check.

I will try to look into the make install problem when I get a chance. (The enhanced GNU Make that I wrote, "remake" may be of help here.)

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Wed 24 Aug 2011 07:52:34 PM UTC, comment #1:

Sorry for being Anonymous -- this is my bug. I didn't notice where the "Register" button was until after I'd already submitted. If anyone's interested in looking further into the install bug, I'm happy to do whatever I can to help. I looked into it a little, but decided it was more worthwhile for me to keep working on my cdio-using project, especially since the binaries still compile properly, and the Linux stuff works (which is what I was really worried about).

I'm fine with providing more information, or doing further digging/debugging with some guidance (I'm regrettably not as well-versed in the ways of autoconf as I should be).

Tianon <tianon>
Wed 24 Aug 2011 07:42:48 PM UTC, original submission:

I went to try to compile the latest git on Cygwin and found that there were some errors from a commit that replaced some sprintfs with snprintfs, and missed a parenthesis and a comma (see attached patch).

Once the patch is applied, libcdio compiles successfully, and I've tested cd-paranoia.exe and it rips beautifully (can't say as much for MinGW, where I got nothing but crackles, but Cygwin is working again which is good).

The only issue I've got left is an error during "make install" (which is easily bypassed by grabbing the compiled binaries directly instead of installing them to a prefix and grabbing them from there).

For brevity, I've narrowed it down to just the install phase for lib, since that's where the error occurs:

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by tianon (Posted a comment)
  • -unavailable- added by tianon (Now I'm registered... Whoops!)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 05 Dec 2011 12:57:35 PM UTCrockyStatusNone=>Works For Me
      Open/ClosedOpen=>Closed
    Thu 25 Aug 2011 04:25:14 AM UTCrockyAssigned toNone=>rocky
    Wed 24 Aug 2011 07:46:25 PM UTCtianonCarbon-Copy-=>Added tianon
    Wed 24 Aug 2011 07:42:48 PM UTCNoneAttached File-=>Added libcdio-windows-ioctl-sizeof-fixes.patch, #23863

    Back to the top


    Powered by Savane 3.1-cleanup1