bugGNU Zile (Zile is Lossy Emacs) - Bugs: bug #34033, Emacs tests fail when comparing...

 
 

bug #34033: Emacs tests fail when comparing against 'Lua Source' in test output

Submitted by:  Gary V. Vaughan <gary>
Submitted on:  Wed 17 Aug 2011 08:48:29 AM UTC  
 
Category: LuaSeverity: 3 - Normal
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 18 Aug 2011 03:28:09 AM UTC, comment #2:

Great idea! Much cleaner than any of my suggestions. Fixed with e8abd20.

Gary V. Vaughan <gary>
Project Administrator
Wed 17 Aug 2011 01:33:24 PM UTC, comment #1:

I actually contemplate two different solutions:

1. Change the Lua code to output "C source". Even I think that is taking Emacs emulation too far. (I would rather Emacs changed to just say "source".)

2. (Preferred): Change the tests so they only copy the first few words of the buffer line rather than the whole line, so that the words "C source" or "Lua source" are no longer captured and compared.

Reuben Thomas <rrt>
Project Administrator
Wed 17 Aug 2011 08:48:29 AM UTC, original submission:

I can think of a few ways to work around this, in order from least liked to most liked:

1. Revert the patch, so that Lua Zile again claims that it has functions implemented in 'C Source', which is pretty unsatisfactory just to satisfy an emacs test.
2. Move the 2 affected tests into zile-only, which would be a shame since the tests do work in emacs too, only we're comparing the output badly.
3. Store the test output with 'C Source' strings, and write a small wrapper for running zile tests that performs a substitution on the output file before the test harness makes a comparison.
4. Store the test output with 'Lua Source' strings, but write a small wrapper for running emacs tests that performs a substitution on the output file before the test harness makes a comparison.
5. Run the substitutions in the test harness itself.

What do you think?

Gary V. Vaughan <gary>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rrt (Posted a comment)
  • -unavailable- added by gary (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 18 Aug 2011 03:28:28 AM UTCgaryOpen/ClosedOpen=>Closed
    Thu 18 Aug 2011 03:28:09 AM UTCgaryStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1