bugGNU Octave - Bugs: bug #33993, __xzip__ with nargout = 0, nargin...

 
 

bug #33993: __xzip__ with nargout = 0, nargin = 4 does not move compressed files

Submitted by:  Orion Poplawski <opoplawski>
Submitted on:  Thu 11 Aug 2011 09:18:28 PM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: Orion PoplawskiOpen/Closed: Closed
Release: 3.4.2Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 12 Aug 2011 12:58:57 AM UTC, comment #1:

Thanks, I've pushed your fix on the stable branch after confirming that it is indeed a regression in expected behaviour:

http://hg.savannah.gnu.org/hgweb/octave/rev/5cc3b7673d25

In the future, if you would like to submit more patches, it would be preferrable if you could do them with Mercurial:

http://jordi.inversethought.com/blog/how-to-write-a-patch-for-octave/
http://www.gnu.org/software/octave/doc/interpreter/How-to-Contribute.html#How-to-Contribute

Regarding unit testing, we do in fact need to write more. If you could provide tests, that would be great. We will be having our next code sprint during September 3 in order to address this precise problem of writing unit tests for all of Octave's functions, or as many as we can get done. Of course, you don't have to wait until then to provide tests. ;-)

Thanks for you attention to detail and for providing fixes for them.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Thu 11 Aug 2011 09:18:28 PM UTC, original submission:

Changeset 12499:a3019189ac51 broke _xzip_ with nargout = 0 and nargin = 4. The compressed files are no longer moved back to the original directory. This breaks pkg build builddir source.

Looks like some unit tests are in order for this and functions like tar if there are going to be significant re-writes.

The attached patch fixes my issue.

Orion Poplawski <opoplawski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23788:  octave-xzip.patch added by opoplawski (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by opoplawski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 12 Aug 2011 12:58:57 AM UTCjordighStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Summary_xzip_ with nargout = 0, nargin = 4 is broken=>_xzip_ with nargout = 0, nargin = 4 does not move compressed files
    Thu 11 Aug 2011 09:18:28 PM UTCopoplawskiAttached File-=>Added octave-xzip.patch, #23788

    Back to the top


    Powered by Savane 3.1-cleanup1