bugGNU Octave - Bugs: bug #33988, tar erroneously complains about...

 
 

bug #33988: tar erroneously complains about its arguments

Submitted by:  Orion Poplawski <opoplawski>
Submitted on:  Thu 11 Aug 2011 04:58:20 PM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: opoplawskiOpen/Closed: Closed
Release: 3.4.2Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 11 Aug 2011 06:27:40 PM UTC, comment #1:

Thanks, I pushed this on the stable branch:

http://hg.savannah.gnu.org/hgweb/octave/rev/93a1d99183fb

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Thu 11 Aug 2011 04:58:20 PM UTC, original submission:

Trying to package up octave package for 3.4.2 and getting:

octave -H -q --no-site-file --eval 'pkg build '\''-verbose'\'' /var/tmp/octave-image-1.0.14-2.fc17.x86_64 /builddir/build/BUILD/image-1.0.14'
warning: creating build directory /var/tmp/octave-image-1.0.14-2.fc17.x86_64
graycomatrix.cc: In function 'octave_value_list Fgraycomatrix(const octave_value_list&, int)':
graycomatrix.cc:98:30: warning: 'Array<T>::Array(octave_idx_type, const T&) [with T = int, octave_idx_type = int]' is deprecated (declared at /usr/include/octave-3.4.2/octave/../octave/Array.h:179) [-Wdeprecated-declarations]
make: Entering directory `/builddir/build/BUILD/image-1.0.14/src'
mkoctfile -Wall _spatial_filtering_.cc
mkoctfile -Wall _bilateral_.cc
mkoctfile -Wall _custom_gaussian_smoothing_.cc
mkoctfile -Wall _boundary_.cc
mkoctfile -Wall bwlabel.cc
mkoctfile -Wall bwfill.cc
mkoctfile -Wall rotate_scale.cc
mkoctfile -Wall hough_line.cc
mkoctfile -Wall graycomatrix.cc
mkoctfile -Wall deriche.cc
mkoctfile -Wall __bwdist.cc
mkoctfile -Wall nonmax_supress.cc
make: Leaving directory `/builddir/build/BUILD/image-1.0.14/src'
copyfile /builddir/build/BUILD/image-1.0.14/src/__bilateral__.oct /builddir/build/BUILD/image-1.0.14/src/__boundary__.oct /builddir/build/BUILD/image-1.0.14/src/__bwdist.oct /builddir/build/BUILD/image-1.0.14/src/__custom_gaussian_smoothing__.oct /builddir/build/BUILD/image-1.0.14/src/__spatial_filtering__.oct /builddir/build/BUILD/image-1.0.14/src/bwfill.oct /builddir/build/BUILD/image-1.0.14/src/bwlabel.oct /builddir/build/BUILD/image-1.0.14/src/deriche.oct /builddir/build/BUILD/image-1.0.14/src/graycomatrix.oct /builddir/build/BUILD/image-1.0.14/src/hough_line.oct /builddir/build/BUILD/image-1.0.14/src/nonmax_supress.oct /builddir/build/BUILD/image-1.0.14/src/rotate_scale.oct /builddir/build/BUILD/image-1.0.14/inst/x86_64-redhat-linux-gnu-api-v45+
error: tar: all arguments must be character strings
error: called from:
error: /usr/share/octave/3.4.2/m/miscellaneous/tar.m at line 46, column 5
error: /usr/share/octave/3.4.2/m/pkg/pkg.m at line 1236, column 7
error: /usr/share/octave/3.4.2/m/pkg/pkg.m at line 602, column 5
error: /usr/share/octave/3.4.2/m/pkg/pkg.m at line 471, column 7

This appears to have been caused by the change set 12500:8f2056646dba which changed:

- if (ischar (tarfile) && iscellstr (files) && ischar (root))
-
- cmd = sprintf ("tar cvf %s -C %s %s", tarfile, root,
- sprintf (" %s", files{:}));
....

to:

+ if (ischar (tarfile) && iscellstr (files) && ischar (root))
+ error ("tar: all arguments must be character strings");
+ endif

Which completely reversed the logic. I think you need:

+ if !(ischar (tarfile) && iscellstr (files) && ischar (root))
+ error ("tar: all arguments must be character strings");
+ endif

Orion Poplawski <opoplawski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23787:  octave-tar.patch added by opoplawski (437B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by opoplawski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 11 Aug 2011 06:27:40 PM UTCjordighStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Summarytar erroneously complains about it\'s arguments=>tar erroneously complains about its arguments
    Thu 11 Aug 2011 04:58:20 PM UTCopoplawskiAttached File-=>Added octave-tar.patch, #23787

    Back to the top


    Powered by Savane 3.1-cleanup1