bugGNU Octave - Bugs: bug #33950, strread in dev src doesn't honor...

 
 

bug #33950: strread in dev src doesn't honor user-specified width for %Ns format

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Fri 05 Aug 2011 08:53:23 AM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 09 Aug 2011 02:45:41 PM UTC, comment #3:

I've applied both patches (http://hg.savannah.gnu.org/hgweb/octave/rev/3509cf60d1f6) and strread works correctly on the sample string that I had posted. Closing this bug.

Rik <rik5>
Project Administrator
Tue 09 Aug 2011 06:57:19 AM UTC, comment #2:

The patch I originally sent in has nothing to do with this one.

AFAICS you've hit a bug, or corner case, in the format-to-column matching code.
Fix attached (diff -u).

While checking this out I also hit bug #33971...

(file #23765)

Philip Nienhuis <philipnienhuis>
Project Member
Mon 08 Aug 2011 11:25:30 PM UTC, comment #1:

Could you also supply a test to verify that this patch is working? I thought I understood it, but I obviously don't. I tried:

I had expected "He" and "Wo" to be returned.

Rik <rik5>
Project Administrator
Fri 05 Aug 2011 08:53:23 AM UTC, original submission:

A small debug thing accidentally left behind in the code.

Changeset attached.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23765:  strread.m.diff_9aug2011 added by philipnienhuis (327B - application/octet-stream)
file #23743:  strread_prcnt_N_s-wdth.patch added by philipnienhuis (712B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 09 Aug 2011 02:45:41 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Tue 09 Aug 2011 06:57:19 AM UTCphilipnienhuisAttached File-=>Added strread.m.diff_9aug2011, #23765
    Mon 08 Aug 2011 11:25:30 PM UTCrik5StatusNone=>Patch Submitted
    Fri 05 Aug 2011 08:53:23 AM UTCphilipnienhuisAttached File-=>Added strread_prcnt_N_s-wdth.patch, #23743

    Back to the top


    Powered by Savane 3.1-cleanup1