bugGNU Octave - Bugs: bug #33922, spqr (removed function) still...

 
 

bug #33922: spqr (removed function) still refered in source

Submitted by:  Andreas Weber <andy1978>
Submitted on:  Mon 01 Aug 2011 06:09:58 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Documentation
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 03 Aug 2011 12:43:03 AM UTC, comment #2:

I pushed your patch in this changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/12defc71072c). I modified it slightly to put spaces after commas in the argument list for qr(). Thanks for finding, and fixing, this issue.

Rik <rik5>
Project Administrator
Tue 02 Aug 2011 07:42:27 AM UTC, comment #1:

I have added a patch for gr.cc

Thanks to Jordi and the IRC channel, this is my first commit of a patch. Andy

Andreas Weber <andy1978>
Project Member
Mon 01 Aug 2011 06:09:58 PM UTC, original submission:

NEWS: ** Deprecated functions.
The following functions were deprecated in Octave 3.2 and have been removed from Octave 3.6.

...
israwcommand spdet spprod
lchol spdiag spqr
...

but some functions still refer to sp* functions for example spqr:

src/DLD-FUNCTIONS/qr.cc-189-@example\n\
src/DLD-FUNCTIONS/qr.cc-190-@group\n\
src/DLD-FUNCTIONS/qr.cc:191:[@var{C},@var{R}] = spqr (@var{A},@var{B})\n\
src/DLD-FUNCTIONS/qr.cc-192-x = @var{R} \\ @var{C}\n\
src/DLD-FUNCTIONS/qr.cc-193-@end group\n\

doc/interpreter/octave.info-3-7814- B' to be calculated as
doc/interpreter/octave.info-3-7815-
doc/interpreter/octave.info-3:7816: [C,R] = spqr (A,B)
doc/interpreter/octave.info-3-7817- x = R \ C

and therefore the generated documentation:
http://www.gnu.org/software/octave/doc/interpreter/Matrix-Factorizations.html

Andreas Weber <andy1978>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23727:  spqr_fix.patch added by andy1978 (1KiB - text/x-patch - qr.cc: fixed reference to removed function spqr and added optional var B to docstring)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by andy1978 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 03 Aug 2011 12:43:03 AM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 02 Aug 2011 07:40:21 AM UTCandy1978Attached File-=>Added spqr_fix.patch, #23727

    Back to the top


    Powered by Savane 3.1-cleanup1