bugGnash - The GNU Flash player - Bugs: bug #33889, Button key event regression

 
 

bug #33889: Button key event regression

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Sat 30 Jul 2011 02:07:31 PM UTC  
 
Category: NoneSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 01 Aug 2011 07:10:39 AM UTC, comment #2:

This is fixed again by reverting, but the test the original commit fixed also now fails again.

Benjamin Wolsey <bwy>
Project Member
Mon 01 Aug 2011 06:52:22 AM UTC, comment #1:

One such game is Kung Fu Special Trainer: http://static.funnygames.eu/games/9/2309/2309.swf (5e5da444aa910832e81c064147a048e7)

Benjamin Wolsey <bwy>
Project Member
Sat 30 Jul 2011 02:07:31 PM UTC, original submission:

The commit 3db73486d8b99425a707e6ab04acf37942303eb8 broke button event handling for some games. The button is being placed and removed before a key event can be received.

There's no attempt to duplicate a button event for a single key (which would, apparently correctly, be rejected by the new code), so I suspect the difference is that the old code kept Buttons alive for longer in a separate key listeners' list. Now the button is destroyed immediately, so the key event isn't handled.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 01 Aug 2011 07:10:47 AM UTCbwyOpen/ClosedOpen=>Closed
    Mon 01 Aug 2011 07:10:39 AM UTCbwyStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1