bugGNU Octave - Bugs: bug #33860, given test fail should consider...

 
 

bug #33860: given test fail should consider calculation error

Submitted by:  Tatsuro MATSUOKA <tmacchant>
Submitted on:  Tue 26 Jul 2011 02:14:03 AM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: NoneAssigned to: Jordi GutiĆ©rrez Hermoso <jordigh>
Originator Name: Open/Closed: Closed
Release: devOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 26 Jul 2011 05:34:55 AM UTC, comment #3:

The changeset in default branch

-%!assert (givens (1,1), [1, 1; -1, 1]/sqrt(2));
+%!assert (givens (1,1), [1, 1; -1, 1]/sqrt(2), 2*eps);

worked correctly.

Tatsuro MATSUOKA <tmacchant>
Tue 26 Jul 2011 04:40:40 AM UTC, comment #2:

The test was carried default branch but not stable branch.

Tatsuro MATSUOKA <tmacchant>
Tue 26 Jul 2011 03:45:12 AM UTC, comment #1:

Thanks for the bug report. I wrote that test during the code sprint, but I guess it was too strict. I've added a small tolerance for it in cset 12881:49553ea11764.

However, I am confused. That test is on the default branch, not on the stable branch. When I do
to switch to the stable branch, I don't see that test in the code anymore. Are you really seeing this on the stable branch? Did it somehow leak from the default branch? Type
to verify that you're on the stable branch.

Jordi GutiƩrrez Hermoso <jordigh>
Project AdministratorIn charge of this item.
Tue 26 Jul 2011 02:14:03 AM UTC, original submission:

Hello

In MinGW build of recent dev source,

test for 'givens' gives

However,

The test should consider calculation errors as,

assert(abs(givens (1,1) - [1, 1; -1, 1] / sqrt (2))< 2e-16);

Regards

Tatsuro

Tatsuro MATSUOKA <tmacchant>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by tmacchant (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Jul 2011 03:45:12 AM UTCjordighAssigned toNone=>jordigh
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1