bugGNU Octave - Bugs: bug #33798, CTRL_CLOSE_EVENT causes windows...

 
 

bug #33798: CTRL_CLOSE_EVENT causes windows error

Submitted by:  Tatsuro MATSUOKA <tmacchant>
Submitted on:  Mon 18 Jul 2011 11:02:25 PM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Segfault, Bus Error, etc.
Status: Need InfoAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 08 Mar 2012 04:44:53 PM UTC, comment #7:

Patch was applied here (http://hg.savannah.gnu.org/hgweb/octave/rev/47fba1dc31b8).

Rik <rik5>
Project Administrator
Tue 06 Mar 2012 10:42:03 PM UTC, comment #6:

The code is already protected by

so further protection by

is meaningless.

Tatsuro MATSUOKA <tmacchant>
Tue 06 Mar 2012 07:39:36 PM UTC, comment #5:

Tatsuro,

Michael is okay to apply your patch. Does your patch apply only to MinGW or also to other Windows platforms?

Your patch should be protected with at least one #ifdef like this.

but perhaps it also needs

Could you re-submit your patch with the code protected by an #ifdef?

Rik <rik5>
Project Administrator
Thu 01 Mar 2012 09:17:09 AM UTC, comment #4:

I didn't test the patch, but looking at it, I don't see how it can be worse than the current behavior. To check whether the exit handlers are working, I'd suggest to attache a handler that does something visible (like writing to a file).

Anyway I think it's safe to apply it.

Michael Goffioul <goffioul>
Project Member
Mon 27 Feb 2012 11:02:56 PM UTC, comment #3:

I have reread the thread

http://octave.1599824.n4.nabble.com/Does-signal-trap-of-CTRL-CLOSE-event-allowable-to-be-used-on-windows-td3663185.html

If Michael state nothing, I will keep the patch locally because I cannot say the patch is the safe.

At the case please close this post.

Tatsuro MATSUOKA <tmacchant>
Mon 27 Feb 2012 10:41:42 PM UTC, comment #2:

The patch is not attached octave source tree.

I would like to hear the Michael Goffioul's opinion because he is the specialist to windows programming.

Michael's mail address is already added to the carbon copy list.

Michael, it would be grateful you will give a comment here.

Tatsuro MATSUOKA <tmacchant>
Mon 27 Feb 2012 05:35:24 PM UTC, comment #1:

Tatsuro, has any patch been applied for the CTRL_CLOSE_EVENT for Octave on Windows?

Rik <rik5>
Project Administrator
Mon 18 Jul 2011 11:02:25 PM UTC, original submission:

Hello

The bug has been known for a long time on octave for windows.
Pressing the [x] button of right upper part of command prompt (console) bar causes windows crash dialog.

Note that the [x] button of right upper part of command prompt is called as CTRL_CLOSE_EVENT in the windows programming.

I will propose to catch CTRL_CLOSE_EVENT and close octave quietly as possible .

I have propose it on the maintainers list.
http://octave.1599824.n4.nabble.com/Does-signal-trap-of-CTRL-CLOSE-event-allowable-to-be-used-on-windows-td3663185.html

Tatsuro MATSUOKA <tmacchant>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23672:  CTRL_CLOSE_EVENT.diff added by tmacchant (676B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goffioul (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by tmacchant (Submitted the item)
  • -unavailable- added by tmacchant
  • -unavailable- added by tmacchant
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 29 Feb 2012 04:21:46 AM UTCrik5Open/ClosedOpen=>Closed
    Mon 27 Feb 2012 05:35:43 PM UTCrik5StatusNone=>Need Info
    Mon 18 Jul 2011 11:02:25 PM UTCtmacchantAttached File-=>Added CTRL_CLOSE_EVENT.diff, #23672
      Carbon-Copy-=>Added -unavailable-
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1