(
Jump to the original submission)
Thu 08 Mar 2012 04:44:53 PM UTC, comment #7:
Patch was applied here (http://hg.savannah.gnu.org/hgweb/octave/rev/47fba1dc31b8).
|
Tue 06 Mar 2012 10:42:03 PM UTC, comment #6:
The code is already protected by
so further protection by
is meaningless.
|
Tue 06 Mar 2012 07:39:36 PM UTC, comment #5:
Tatsuro,
Michael is okay to apply your patch. Does your patch apply only to MinGW or also to other Windows platforms?
Your patch should be protected with at least one #ifdef like this.
but perhaps it also needs
Could you re-submit your patch with the code protected by an #ifdef?
|
Thu 01 Mar 2012 09:17:09 AM UTC, comment #4:
I didn't test the patch, but looking at it, I don't see how it can be worse than the current behavior. To check whether the exit handlers are working, I'd suggest to attache a handler that does something visible (like writing to a file).
Anyway I think it's safe to apply it.
|
Mon 27 Feb 2012 11:02:56 PM UTC, comment #3:
I have reread the thread
http://octave.1599824.n4.nabble.com/Does-signal-trap-of-CTRL-CLOSE-event-allowable-to-be-used-on-windows-td3663185.html
If Michael state nothing, I will keep the patch locally because I cannot say the patch is the safe.
At the case please close this post.
|
Mon 27 Feb 2012 10:41:42 PM UTC, comment #2:
The patch is not attached octave source tree.
I would like to hear the Michael Goffioul's opinion because he is the specialist to windows programming.
Michael's mail address is already added to the carbon copy list.
Michael, it would be grateful you will give a comment here.
|
Mon 27 Feb 2012 05:35:24 PM UTC, comment #1:
Tatsuro, has any patch been applied for the CTRL_CLOSE_EVENT for Octave on Windows?
|
Mon 18 Jul 2011 11:02:25 PM UTC, original submission:
Hello
The bug has been known for a long time on octave for windows.
Pressing the [x] button of right upper part of command prompt (console) bar causes windows crash dialog.
Note that the [x] button of right upper part of command prompt is called as CTRL_CLOSE_EVENT in the windows programming.
I will propose to catch CTRL_CLOSE_EVENT and close octave quietly as possible .
I have propose it on the maintainers list.
http://octave.1599824.n4.nabble.com/Does-signal-trap-of-CTRL-CLOSE-event-allowable-to-be-used-on-windows-td3663185.html
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 5 latest changes.